set -- mistakenly outputs shell variables and shell functions

[ko1nksm]

set -- must clear positional parameters.

$ brush --version
brush 0.2.14 (git:dd1d39c)

$ brush -c 'set --'
BASH=brush
BASH_VERSINFO=([0]="5" [1]="2" [2]="15" [3]="1" [4]="release" [5]="unknown")
BASH_VERSION=5.2.15(1)-release
COMP_WORDBREAKS='
  ︙

$ bash -c 'set --'
(nothing)

[reubeno]

Thanks for filing this issue. This one may be tricky, as we're relying on the clap-rs command-line parser to parse arguments for built-in commands; unfortunately, I don't think there's any way for our code to distinguish between set and set --.

We'll need to think on this for a bit.

(For posterity, note that these two command-lines also have different side effects; set does not reset $1, etc. but set -- does.)

[reubeno]

Thanks for reporting this issue!

After some thought (and investigation), it looks like we can use the same workaround that had been done for echo in #147. I've submitted a PR with a proposed fix.

[ko1nksm]

Apparently, a small issue remains.

$ brush --version
brush 0.2.14 (git:cf45a9f)

$  brush -c 'set -- a ${1:-+}; echo "$@"'
a --+

$ bash -c 'set -- a ${1:-+}; echo "$@"'
a +

FYI. This bug was accidentally discovered because the 63rd customizable character in base64 is +.
https://github.com/ko1nksm-shlab/sh-base64/blob/17cece824649d60962bed3bea44203d266d85ebd/base64.sh#L10

[reubeno]

You're right! We have some logic to work around clap-rs's limitations in supporting + options. It sounds like that workaround is incorrectly getting applied to the positional arguments.

I'll reactivate this issue and look at addressing this. Thanks again for the clear details.