Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable client side validation on the filter field #57

Closed
ahmednfwela opened this issue Jul 3, 2023 · 2 comments
Closed

Disable client side validation on the filter field #57

ahmednfwela opened this issue Jul 3, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@ahmednfwela
Copy link

ahmednfwela commented Jul 3, 2023 •
edited
Loading

Describe the bug
The filter field has many validation bugs while searching, and it doesn't support all the latest changes (like IS NULL, IS EMPTY).
so I suggest disabling the client side validation altogether and leaving only the server-side validation

Screenshots
image
image
image

Environments (please complete the following information):

  • OS: Windows
  • Chrome
  • Version 0.4.0

cc @riccox
@ahmednfwela ahmednfwela added the bug Something isn't working label Jul 3, 2023
@riccox riccox moved this to 👁 In Progress in Meilisearch-UI Roadmap Jul 3, 2023
@riccox riccox closed this as completed in 5f1a271 Jul 3, 2023
@github-project-automation github-project-automation bot moved this from 👁 In Progress to 🍻 Done in Meilisearch-UI Roadmap Jul 3, 2023
@riccox riccox mentioned this issue Jul 3, 2023
Merged
@riccox
Copy link
Owner

riccox commented Jul 3, 2023

@ahmednfwela Thanks!
Fixed in new release version v0.4.1.
Note that it will take a while to ci build & publish.

@ahmednfwela
Copy link
Author

@riccox works perfectly! thanks for your amazing work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Meilisearch-UI Roadmap
Status: 🍻 Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@riccox @ahmednfwela