Skip to content
This repository was archived by the owner on Feb 24, 2020. It is now read-only.

Add tests for fetching over http instead of just https #1795

Open
blixtra opened this issue Nov 25, 2015 · 7 comments
Open

Add tests for fetching over http instead of just https #1795

blixtra opened this issue Nov 25, 2015 · 7 comments

Comments

@blixtra
Copy link
Collaborator

blixtra commented Nov 25, 2015

Currently we only test fetching over https connections. We should add some functional tests for http as well.

Related, what should be the behavior if insecure-options=tls is specified?

@alban
Copy link
Member

alban commented Nov 25, 2015

Maybe we need a new --insecure-options=http option to support downloads when the discovery protocol returns a http:// URL.

@iaguis
Copy link
Member

iaguis commented Nov 30, 2015

Maybe we need a new --insecure-options=http option to support downloads when the discovery protocol returns a http:// URL.

Isn't that what --insecure-options=tls is supposed to do?

@krnowak
Copy link
Collaborator

krnowak commented Nov 30, 2015

@iaguis: tls skips TLS certificate checks, but it still downloads over HTTPS.

There are two new options to consider - whether to allow downloading over HTTP and whether to allow sending credentials over HTTP.

@krnowak
Copy link
Collaborator

krnowak commented Nov 30, 2015

I think this will need some work on appc spec side - appc/spec#545

@iaguis
Copy link
Member

iaguis commented Jan 19, 2016

Now that #1945 and appc/spec#551 are merged, do we have everything we need to start implementing this?

@krnowak
Copy link
Collaborator

krnowak commented Jan 19, 2016

Yeah, merge #1977 first. :P It has some work on a test aci server (so we can make it to accept HTTP connections instead of HTTPS) instead of downloading images from remote locations and thus making TestFetch even more unreliable.

@alban alban modified the milestones: v1.0.0, v0.16.0 Jan 19, 2016
@alban
Copy link
Member

alban commented Jan 19, 2016

Depends on #1977 => update priority and milestone.

Do we still need the "dependency appc/spec"? appc/spec#551 was merged in spec 0.7.4 (included in rkt) and appc/spec#545 was closed.

@iaguis iaguis modified the milestones: v1.1.0, v1.0.0 Jan 29, 2016
@iaguis iaguis modified the milestones: v1+, v1.1.0 Feb 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants