Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create a rock: Add Package to Workspace command #35

Closed
doudou opened this issue Jan 19, 2018 · 7 comments
Closed

create a rock: Add Package to Workspace command #35

doudou opened this issue Jan 19, 2018 · 7 comments

Comments

@doudou
Copy link
Member

doudou commented Jan 19, 2018

Just in the last week, this would have saved me a lot of pain and suffering.

Allow the user to add a package in the workspace by picking it in a list. We would either look at the workspaces that are already opened. So, one must already have at least one package in its workspace, but I don't think it's a bad thing.

@g-arjones
Copy link
Contributor

I don't think I understand this one.. You mean showing a quick pick ui with all orogen/cmake/autotools/ruby packages defined in the installation manifest?

@doudou
Copy link
Member Author

doudou commented Jan 19, 2018

You mean showing a quick pick ui with all orogen/cmake/autotools/ruby packages defined in the installation manifest?

Yes, and add the selected package to the workspace.

@g-arjones
Copy link
Contributor

I like the idea... Should we filter supported packages (configuration/ruby/orogen/cmake/autotools)?

@doudou
Copy link
Member Author

doudou commented Jan 19, 2018

should we filter supported packages (configuration/ruby/orogen/cmake/autotools)?

I wouldn't. Any package in the installation manifest should do.

@g-arjones
Copy link
Contributor

g-arjones commented Jan 19, 2018

There was microsoft/vscode@020e4dc but it was removed.. We should probably watch microsoft/vscode#35407

@g-arjones
Copy link
Contributor

For the record: microsoft/vscode#42026

@doudou
Copy link
Member Author

doudou commented Feb 9, 2018

It got published in vscode 1.20, but unfortunately only as a "proposed API", which means that one cannot use it if running "main" vscode (you need either a special flag or running code insiders)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants