Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error using dynamic group() and specialized formats together #1236

Closed
3 tasks done
wlandau opened this issue Apr 6, 2020 · 0 comments
Closed
3 tasks done

Error using dynamic group() and specialized formats together #1236

wlandau opened this issue Apr 6, 2020 · 0 comments
Assignees

Comments

@wlandau
Copy link
Member

wlandau commented Apr 6, 2020

Prework

Description

Dynamic group() appears to clash with specialized formats (ropensci-books/drake#155 (comment), cc @adamaltmejd). It is because $mget() does not respect the "decorated" part of drake's decorated storr.

Reproducible example

library(drake)

plan <- drake_plan(
  a = c(1, 2, 3),
  dts = target(
    list(a = a, b = 4),
    dynamic = map(a),
    format = "qs"
  ),
  final = target(
    list(dts),
    dynamic = group(dts),
    format = "qs"
  )
)

make(plan)
#> ▶ target a
#> ▶ dynamic dts
#> > subtarget dts_0a25b599
#> > subtarget dts_6aab08ab
#> > subtarget dts_a150a51a
#> ■ finalize dts
#> ▶ dynamic final
#> > subtarget final_eec507d0
#> Error: Can't find vctrs or base methods for concatenation.
#> vctrs methods must be implemented for class `drake_format_qs`.
#> See <https://vctrs.r-lib.org/articles/s3-vector.html>.

Created on 2020-04-06 by the reprex package (v0.3.0)

Expected result

No error.

@wlandau wlandau self-assigned this Apr 6, 2020
@wlandau wlandau changed the title Error using dynamic group() and custom formats together Error using dynamic group() and specialized formats together Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant