Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cached_planned() and cached_unplanned() not working with non-standard cache locations #1268

Closed
3 tasks done
matthiasgomolka opened this issue Jun 4, 2020 · 1 comment
Closed
3 tasks done
Assignees

Comments

@matthiasgomolka
Copy link
Contributor

matthiasgomolka commented Jun 4, 2020

Prework

Description

If the drake cache is not in the standard location, the functions cached_planned() and cached_unplanned() do not work.

Reproducible example

library(drake)

# create cache
cache_path <- file.path(tempdir(), ".drake")
my_cache <- new_cache(cache_path)

# create and make plan
plan <- drake_plan(iris = iris)
make(plan, cache = my_cache)
#> ▶ target iris

# change and remake plan
plan <- drake_plan(mtcars = mtcars)
make(plan, cache = my_cache)
#> ▶ target mtcars

# show error
cached_unplanned(plan, cache = my_cache)
Error: $ operator is invalid for atomic vectors

Created on 2020-06-04 by the reprex package (v0.3.0)

Expected result

This should work, independently from the cache location.

Session info

Session info
devtools::session_info()
#> ─ Session info ───────────────────────────────────────────────────────────────
#>  setting  value                       
#>  version  R version 4.0.0 (2020-04-24)
#>  os       elementary OS 5.1.5 Hera    
#>  system   x86_64, linux-gnu           
#>  ui       X11                         
#>  language EN                          
#>  collate  de_DE.UTF-8                 
#>  ctype    de_DE.UTF-8                 
#>  tz       Europe/Berlin               
#>  date     2020-06-04                  
#> 
#> ─ Packages ───────────────────────────────────────────────────────────────────
#>  package     * version     date       lib source                            
#>  assertthat    0.2.1       2019-03-21 [1] CRAN (R 4.0.0)                    
#>  backports     1.1.7       2020-05-13 [1] CRAN (R 4.0.0)                    
#>  base64url     1.4         2018-05-14 [1] CRAN (R 4.0.0)                    
#>  callr         3.4.3       2020-03-28 [1] CRAN (R 4.0.0)                    
#>  cli           2.0.2       2020-02-28 [1] CRAN (R 4.0.0)                    
#>  colorout      1.2-2       2020-04-28 [1] Github (jalvesaq/colorout@726d681)
#>  crayon        1.3.4       2017-09-16 [1] CRAN (R 4.0.0)                    
#>  desc          1.2.0       2018-05-01 [1] CRAN (R 4.0.0)                    
#>  devtools      2.3.0       2020-04-10 [1] CRAN (R 4.0.0)                    
#>  digest        0.6.25      2020-02-23 [1] CRAN (R 4.0.0)                    
#>  drake       * 7.12.2.9000 2020-06-04 [1] Github (ropensci/drake@53214ac)   
#>  ellipsis      0.3.1       2020-05-15 [1] CRAN (R 4.0.0)                    
#>  evaluate      0.14        2019-05-28 [1] CRAN (R 4.0.0)                    
#>  fansi         0.4.1       2020-01-08 [1] CRAN (R 4.0.0)                    
#>  filelock      1.0.2       2018-10-05 [1] CRAN (R 4.0.0)                    
#>  fs            1.4.1       2020-04-04 [1] CRAN (R 4.0.0)                    
#>  glue          1.4.1       2020-05-13 [1] CRAN (R 4.0.0)                    
#>  highr         0.8         2019-03-20 [1] CRAN (R 4.0.0)                    
#>  hms           0.5.3       2020-01-08 [1] CRAN (R 4.0.0)                    
#>  htmltools     0.4.0       2019-10-04 [1] CRAN (R 4.0.0)                    
#>  igraph        1.2.5       2020-03-19 [1] CRAN (R 4.0.0)                    
#>  knitr         1.28        2020-02-06 [1] CRAN (R 4.0.0)                    
#>  lifecycle     0.2.0       2020-03-06 [1] CRAN (R 4.0.0)                    
#>  magrittr      1.5         2014-11-22 [1] CRAN (R 4.0.0)                    
#>  memoise       1.1.0       2017-04-21 [1] CRAN (R 4.0.0)                    
#>  pillar        1.4.4       2020-05-05 [1] CRAN (R 4.0.0)                    
#>  pkgbuild      1.0.8       2020-05-07 [1] CRAN (R 4.0.0)                    
#>  pkgconfig     2.0.3       2019-09-22 [1] CRAN (R 4.0.0)                    
#>  pkgload       1.1.0       2020-05-29 [1] CRAN (R 4.0.0)                    
#>  prettyunits   1.1.1       2020-01-24 [1] CRAN (R 4.0.0)                    
#>  processx      3.4.2       2020-02-09 [1] CRAN (R 4.0.0)                    
#>  progress      1.2.2       2019-05-16 [1] CRAN (R 4.0.0)                    
#>  ps            1.3.3       2020-05-08 [1] CRAN (R 4.0.0)                    
#>  R6            2.4.1       2019-11-12 [1] CRAN (R 4.0.0)                    
#>  Rcpp          1.0.4.6     2020-04-09 [1] CRAN (R 4.0.0)                    
#>  remotes       2.1.1       2020-02-15 [1] CRAN (R 4.0.0)                    
#>  rlang         0.4.6       2020-05-02 [1] CRAN (R 4.0.0)                    
#>  rmarkdown     2.2         2020-05-31 [1] CRAN (R 4.0.0)                    
#>  rprojroot     1.3-2       2018-01-03 [1] CRAN (R 4.0.0)                    
#>  sessioninfo   1.1.1       2018-11-05 [1] CRAN (R 4.0.0)                    
#>  storr         1.2.1       2018-10-18 [1] CRAN (R 4.0.0)                    
#>  stringi       1.4.6       2020-02-17 [1] CRAN (R 4.0.0)                    
#>  stringr       1.4.0       2019-02-10 [1] CRAN (R 4.0.0)                    
#>  testthat      2.3.2       2020-03-02 [1] CRAN (R 4.0.0)                    
#>  tibble        3.0.1       2020-04-20 [1] CRAN (R 4.0.0)                    
#>  txtq          0.2.0       2019-10-15 [1] CRAN (R 4.0.0)                    
#>  usethis       1.6.1       2020-04-29 [1] CRAN (R 4.0.0)                    
#>  vctrs         0.3.0       2020-05-11 [1] CRAN (R 4.0.0)                    
#>  withr         2.2.0       2020-04-20 [1] CRAN (R 4.0.0)                    
#>  xfun          0.14        2020-05-20 [1] CRAN (R 4.0.0)                    
#>  yaml          2.2.1       2020-02-01 [1] CRAN (R 4.0.0)                    
#> 
#> [1] /home/gomolka/R/x86_64-pc-linux-gnu-library/4.0
#> [2] /usr/local/lib/R/site-library
#> [3] /usr/lib/R/site-library
#> [4] /usr/lib/R/library

Details

This error can be solved by adding cache = cache as done here in lines 694 and 743. I'm working on a PR to adress this issue.

@wlandau
Copy link
Member

wlandau commented Jun 6, 2020

Fixed in 101e113.

@wlandau wlandau closed this as completed Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants