Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

potential breaking change - should default vector class be changed to sf from sp ? #65

Closed
andysouth opened this issue Jan 12, 2023 · 1 comment

Comments

@andysouth
Copy link
Contributor

Currently the default returned vector class is sp ideally it would be sf, but this could be a breaking change for existing workflows.

If we changed it, the following would still work in existing workflows

ne_countries(returnclass='sf')
ne_countries(returnclass='sp')
ne_download(returnclass='sf')
ne_download(returnclass='sp')

But workflows with these could break.

ne_countries()
ne_download()

Thanks @rsbivand @Nowosad for the useful comments. Putting into own issue here.

#63 (comment)

Links to https://r-spatial.org/r/2022/12/14/evolution2.html

@mdsumner
Copy link

mdsumner commented Jan 25, 2023

my opinion, create new functions '_sf()', '_Spat()', '_wk()', maintain the old behaviour for as long as sf and sp work. New formats, new functions for when change inevitably comes again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants