Keep isAdvisoryApplicable to preserve API

Its not actually used anywhere in libdnf.

Author: kontura

libdnf/utils/utils.cpp

@@ -24,23 +24,12 @@ namespace libdnf {
 
 bool isAdvisoryApplicable(libdnf::Advisory & advisory, DnfSack * sack)
 {
-    auto moduleContainer = dnf_sack_get_module_container(sack);
-    if (!moduleContainer) {
-        return true;
-    }
-    auto moduleAdvisories = advisory.getModules();
-    if (moduleAdvisories.empty()) {
-        return true;
-    }
-    for (auto & moduleAdvisory: moduleAdvisories) {
-        if (const char * name = moduleAdvisory.getName()) {
-            if (const char * stream = moduleAdvisory.getStream()) {
-                if (moduleContainer->isEnabled(name, stream)) {
-                    return true;
-                }
-            }
+    for (auto & advisoryModule: advisory.getModules()) {
+        if (advisoryModule.isApplicable()) {
+            return true;
         }
     }
+
     return false;
 }
 

libdnf/utils/utils.hpp

@@ -8,6 +8,7 @@
 #define REPOID_CHARS ASCII_LETTERS DIGITS "-_.:"
 
 #include "libdnf/sack/advisory.hpp"
+#include "libdnf/dnf-utils.h"
 
 #include <functional>
 #include <string>
@@ -36,6 +37,7 @@ class Finalizer {
     std::function<void()> func;
 };
 
+DEPRECATED("advisory now provides getApplicablePackages and each AdvisoryModule provides isApplicable.")
 bool isAdvisoryApplicable(Advisory & advisory, DnfSack * sack);
 
 namespace string {