Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finch does not support logging driver "none" #670

Open
pruszel opened this issue Oct 31, 2023 · 3 comments
Open

Finch does not support logging driver "none" #670

pruszel opened this issue Oct 31, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@pruszel
Copy link

pruszel commented Oct 31, 2023

Describe the bug
When I use the logging configuration for my compose service with the driver option set to "none", then I get a fatal error and am unable to start my compose service.

Steps to reproduce
Given the following compose service definition inside docker-compose.yaml:

version: "3.7"

services:
    elasticsearch:
        image: docker.elastic.co/elasticsearch/elasticsearch:6.5.1
        environment:
            - cluster.name=docker-cluster
            - bootstrap.memory_lock=true
            - "ES_JAVA_OPTS=-Xms512m -Xmx512m"
        ulimits:
            memlock:
                soft: -1
                hard: -1
            nofile:
                soft: 65536
                hard: 65536
        logging:
            driver: "none"
        volumes:
            - esdata:/usr/share/elasticsearch/data:delegated
        ports:
            - 9201:9200
        networks:
            - dev

networks:
    dev:
volumes:
    esdata:

When I run finch compose up elasticsearch I get the following output:

INFO[0000] Ensuring image docker.elastic.co/elasticsearch/elasticsearch:6.5.1
INFO[0000] Creating container myapp-elasticsearch-1
FATA[0000] unknown logging driver "none": not found
FATA[0000] error while creating container myapp-elasticsearch-1: exit status 1
FATA[0000] exit status 1

I also tried to use the logging configuration with the driver: "none" option for a different service and got the same result.

Expected behavior
I expected the elasticsearch service to start successfully.

Screenshots or logs
N/A

Additional context
finch-support-20231031104304.zip

@pruszel pruszel added the bug Something isn't working label Oct 31, 2023
@austinvazquez
Copy link
Member

Hi @peterlopez , thanks for the report.

I have looked into the gap and found this would require an upstream change to nerdctl. I have asked maintainers to consider this use case for containerd/nerdctl#1039.

@coderbirju
Copy link
Contributor

'none' logger feature has been accepted upstream, should be available on nerdctl 2.0.
#3633

@pruszel
Copy link
Author

pruszel commented Dec 16, 2024

@coderbirju that's great news. Any idea when nerdctl 2.0 will be supported by Finch? I tried using logging driver "none" with Finch version v1.4.3 released recently and it doesn't appear to use nerdctl 2.0 as I still got the same output as reported initially.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants