Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compat does not implement BufRead for AsyncBufRead implementations #1865

Open
farnz opened this issue Sep 13, 2019 · 0 comments
Open

Compat does not implement BufRead for AsyncBufRead implementations #1865

farnz opened this issue Sep 13, 2019 · 0 comments
Labels
A-compat Area: futures::compat C-feature-request

Comments

@farnz
Copy link

farnz commented Sep 13, 2019

Some older code expects that a tokio-0.1 AsyncRead implements not just Read, which is correctly handled by Compat, but also std::io::BufRead.

Could the Compat wrapper struct implement BufRead for AsyncBufRead new-style async I/O implementations? That way, in combination with BufReader, old code can be made to run for the duration of an incremental port.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-compat Area: futures::compat C-feature-request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@farnz @cramertj @taiki-e