Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zero exit code when plugin not found #893

Closed
chinedufn opened this issue Mar 25, 2019 · 3 comments
Closed

Zero exit code when plugin not found #893

chinedufn opened this issue Mar 25, 2019 · 3 comments
Labels
A-CLI Area: CLI

Comments

@chinedufn
Copy link

chinedufn commented Mar 25, 2019

Problem

I started adding the mdbook-linkcheck plugin to my book build process and was confused when CI was still passing even though I had forgotten to install the plugin in my ci config.

#!/bin/bash -eo pipefail
(cd book && mdbook build) && cargo doc --no-deps --document-private-items -p foo && cp -R target/doc book/book/api
2019-03-25 16:25:00 [INFO] (mdbook::book): Book building has started
2019-03-25 16:25:00 [INFO] (mdbook::book): Running the html backend
2019-03-25 16:25:01 [INFO] (mdbook::book): Running the linkcheck backend
2019-03-25 16:25:01 [INFO] (mdbook::renderer): Invoking the "linkcheck" renderer
2019-03-25 16:25:01 [WARN] (mdbook::renderer): The command wasn't found, is the "linkcheck" backend installed?
2019-03-25 16:25:01 [WARN] (mdbook::renderer): 	Command: mdbook-linkcheck
 Documenting tw v0.1.11 (/root/foo-barg/app/crates/foo-bar-cli)
    Finished dev [unoptimized + debuginfo] target(s) in 2.16s

Expected Behavior

Would expect that mdbook build would fail with a non zero exit code if we tried to use a plugin that it couldn't find.

@Dylan-DPC-zz
Copy link

hi @chinedufn can you send a PR that makes the required change?

@segfaultsourcery
Copy link
Contributor

This has been sitting idle for a while, and it's fairly low hanging fruit, so I fixed it.

@ehuss
Copy link
Contributor

ehuss commented Jun 23, 2020

I think this is closed by #1122.

@ehuss ehuss closed this as completed Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CLI Area: CLI
Projects
None yet
Development

No branches or pull requests

4 participants