Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2021: Switch default to 2021 #1065

Closed
ehuss opened this issue Jul 9, 2021 · 2 comments · Fixed by #1125
Closed

2021: Switch default to 2021 #1065

ehuss opened this issue Jul 9, 2021 · 2 comments · Fixed by #1125
Labels
A-edition-2021 Area: Edition 2021

Comments

@ehuss
Copy link
Contributor

ehuss commented Jul 9, 2021

The default for tests needs to be update to 2021. This involves changing this line to 2021, and fixing any broken tests.

Note that this is blocked on a new mdbook being published (I will try to do that soon). There will also need to be a new mdbook published once 2021 is stabilized on nightly.

@ehuss ehuss added the A-edition-2021 Area: Edition 2021 label Jul 9, 2021
@mattheww
Copy link
Contributor

I have run mdbook test using current mdbook master and edition 2021, and the only failing test is the one addressed by #1110.

(mdbook 0.4.13 isn't new enough to allow changing book.toml yet, at least
when using stable rustc.)

@ehuss
Copy link
Contributor Author

ehuss commented Nov 27, 2021

Thanks for taking a look @mattheww! The reference tests with nightly rustc, so I think using 0.4.13 should be fine for now. I'll look at pushing an update to resolve that, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-edition-2021 Area: Edition 2021
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants