Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-Zthreads=8 starts panicking a lot more frequently since today's nightly #130088

Closed
flippette opened this issue Sep 7, 2024 · 4 comments · Fixed by #130094
Closed

-Zthreads=8 starts panicking a lot more frequently since today's nightly #130088

flippette opened this issue Sep 7, 2024 · 4 comments · Fixed by #130094
Labels
C-bug Category: This is a bug. I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ S-needs-repro Status: This issue has no reproduction and needs a reproduction to make progress. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-compiler-parallel Working group: Parallelizing the compiler WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Comments

@flippette
Copy link

flippette commented Sep 7, 2024

Pretty much what the title says, I've narrowed it down to -Zthreads=8 and today's nightly with the following:

$ rustup toolchain list
nightly-2024-09-05-x86_64-unknown-linux-gnu
nightly-2024-09-06-x86_64-unknown-linux-gnu
nightly-x86_64-unknown-linux-gnu (default)
$ rustc +nightly-2024-09-05 -V
rustc 1.83.0-nightly (4ac7bcbaa 2024-09-04)
$ rustc +nightly-2024-09-06 -V
rustc 1.83.0-nightly (9c01301c5 2024-09-05)
$ rustc -V
rustc 1.83.0-nightly (26b5599e4 2024-09-06)
$ for i in $(seq 1 64); do cargo +nightly-2024-09-05 build -q; cargo clean -q; done
$ echo $?
0
$ for i in $(seq 1 64); do cargo +nightly-2024-09-06 build -q; cargo clean -q; done
$ echo $?
0
$ for i in $(seq 1 64); do env RUSTFLAGS="-Zthreads=1" cargo build -q; cargo clean; done
$ echo $?
0
$ for i in $(seq 1 64); do cargo build -q; cargo clean -q; done
<almost immediately ICEs>

I've attached some rustc backtraces.
rustc-ice-2024-09-07T19_02_57-44339.txt
rustc-ice-2024-09-07T19_40_47-164056.txt
rustc-ice-2024-09-07T19_40_45-162317.txt
rustc-ice-2024-09-07T19_40_44-161289.txt

@flippette flippette added C-bug Category: This is a bug. I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 7, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Sep 7, 2024
@flippette flippette changed the title -Zthreads=8 starts panicking a lot more frequently since nightly-2024-09-06 -Zthreads=8 starts panicking a lot more frequently since today's nightly Sep 7, 2024
@matthiaskrgr
Copy link
Member

probably duplicate of #129112 but made more prevalent by next solver

@jieyouxu jieyouxu added WG-compiler-parallel Working group: Parallelizing the compiler WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Sep 7, 2024
@jieyouxu
Copy link
Member

jieyouxu commented Sep 7, 2024

Is it possible to provide a link to or a snippet of a reproducer? I know it probably happens to various crates, but it still would be nice to have something that reproduces.

@jieyouxu jieyouxu added the S-needs-repro Status: This issue has no reproduction and needs a reproduction to make progress. label Sep 7, 2024
@nuudlman
Copy link

nuudlman commented Sep 7, 2024

See #130089 for an attached repro.

@flippette
Copy link
Author

The repro case is basically the same as #130089, but with other crates mentioned in the ICE logs from the issue comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ S-needs-repro Status: This issue has no reproduction and needs a reproduction to make progress. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-compiler-parallel Working group: Parallelizing the compiler WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants