Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rustdoc error in armv7 -neon with target_feature fp-armv8 #136755

Closed
sayantn opened this issue Feb 9, 2025 · 1 comment
Closed

Rustdoc error in armv7 -neon with target_feature fp-armv8 #136755

sayantn opened this issue Feb 9, 2025 · 1 comment
Labels
A-target-feature Area: Enabling/disabling target features like AVX, Neon, etc. C-bug Category: This is a bug. O-Arm Target: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 state T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@sayantn
Copy link
Contributor

sayantn commented Feb 9, 2025

I tried this code:

#![feature(arm_target_feature)]

#[target_feature(enable = "fp-armv8")]
unsafe fn foo() {}

This always compiles, but in armv7 targets that have -neon target-feature, running rustdoc on it produces the error

error: target feature `fp-armv8` cannot be enabled with `#[target_feature]`: Rust ties `fp-armv8` to `neon`
     --> crates/core_arch/src/arm_shared/neon/generated.rs:15739:48
      |
15739 | #[cfg_attr(target_arch = "arm", target_feature(enable = "fp-armv8,v8"))]
      |                                                ^^^^^^^^^^^^^^^^^^^^^^

Meta

rustc --version --verbose:

rustc 1.86.0-nightly (a9e7b3048 2025-02-07)
binary: rustc
commit-hash: a9e7b30487235621751cc628f170c0f15fb215c4
commit-date: 2025-02-07
host: x86_64-unknown-linux-gnu
release: 1.86.0-nightly
LLVM version: 19.1.7

Related: #133417, #134511

@rustbot label A-target-feature O-Arm T-rustdoc

@sayantn sayantn added the C-bug Category: This is a bug. label Feb 9, 2025
@rustbot rustbot added needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. A-target-feature Area: Enabling/disabling target features like AVX, Neon, etc. O-Arm Target: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 state T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Feb 9, 2025
@Noratrieb
Copy link
Member

it looks like this is a subset of the general rustdoc target feature issue in #137366, so I'm closing it as a duplicate

@Noratrieb Noratrieb reopened this Mar 1, 2025
@Noratrieb Noratrieb removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-target-feature Area: Enabling/disabling target features like AVX, Neon, etc. C-bug Category: This is a bug. O-Arm Target: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 state T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants