Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large const alloc does not fail gracefully on AIX #137966

Closed
mustartt opened this issue Mar 3, 2025 · 2 comments
Closed

Large const alloc does not fail gracefully on AIX #137966

mustartt opened this issue Mar 3, 2025 · 2 comments

Comments

@mustartt
Copy link
Contributor

mustartt commented Mar 3, 2025

The following test cases either hangs or tries to honor the allocation and get sigkilled on AIX.

tests/ui/consts/large_const_alloc.rs

const FOO: () = {
    // 128 TiB, unlikely anyone has that much RAM
    let x = [0_u8; (1 << 47) - 1];
    //~^ ERROR evaluation of constant value failed
};

tests/ui/consts/promoted_running_out_of_memory_issue-130687.rs
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Mar 3, 2025
@workingjubilee
Copy link
Member

I do not believe the code in question is testing "if we fail, fail gracefully", but rather that we handle the failure case of failing to allocate at all. Hitting SIGKILL is an acceptable consequence.

@mustartt
Copy link
Contributor Author

mustartt commented Mar 4, 2025

I guess getting SIGKILL is an acceptable result vs passing. Regardless these these large const alloc tests does not interact well on AIX, as it continuously requests page space until it runs out.

I will close this and mark #137967 and interacting badly. Thanks for the insight :)

@mustartt mustartt closed this as completed Mar 4, 2025
@jieyouxu jieyouxu removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants