Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builtin macro pattern separator #63039

Closed
Undin opened this issue Jul 27, 2019 · 4 comments
Closed

Builtin macro pattern separator #63039

Undin opened this issue Jul 27, 2019 · 4 comments

Comments

@Undin
Copy link
Contributor

Undin commented Jul 27, 2019

Since #62243 builtin macros use , as a separator between different patterns. Although, all other macros use ; instead.
Is it intended change?
This change breaks parser in IntelliJ Rust plugin. Should we adjust our parser or it should be fixed from stdlib side?

@Undin
Copy link
Contributor Author

Undin commented Jul 27, 2019

@petrochenkov

@petrochenkov
Copy link
Contributor

The comma is not specific to built-in macros, but rather to unstable macro macros in general (which are currently used to define built-in macros).

So, it's reasonable for IntelliJ to adjust its parser if it wants to support unstable code.

@petrochenkov
Copy link
Contributor

(Note that the comma itself is pretty questionable, so it's likely that it will be changed into something else, for example no separator at all, once macro macros are closer to stabilization.)

@Undin
Copy link
Contributor Author

Undin commented Jul 27, 2019

@petrochenkov Thanks for quick reply!
Then we will adjust our parser

@Undin Undin closed this as completed Jul 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants