Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove intrinsics in tests that are in mini_core #637

Closed
antoyo opened this issue Feb 23, 2025 · 5 comments
Closed

Remove intrinsics in tests that are in mini_core #637

antoyo opened this issue Feb 23, 2025 · 5 comments
Labels
good first issue Good for newcomers

Comments

@antoyo
Copy link
Contributor

antoyo commented Feb 23, 2025

Like this one: https://github.com/rust-lang/rust/pull/137489/files#diff-d3024326688596a6c1c4e0d9cc81254a24c3267d0dcdc250917a755a0547a446

@madhav-madhusoodanan
Copy link
Contributor

Hi, I'd love to work on updating the tests.

I would be grateful if you could share some context of why we need to remove the intrinsics that are in mini_core.

@antoyo
Copy link
Contributor Author

antoyo commented Feb 25, 2025

Some examples, like this one still has a copy of a mini core library.

Please remove this code in all examples and include mini_core like in this example.

@madhav-madhusoodanan
Copy link
Contributor

madhav-madhusoodanan commented Feb 26, 2025

By importing mini_core, would example/mini_core.rs be loaded?

And Copy, Receiver traits (that are in files like tests/run/abort1.rs ) would be replaced by the definitions in mini_core, right?

Also, functions that are annotated with rustc_intrinsic_must_be_overridden would lose their body.

Is my observation correct? Only wanted to clarify what's happening.

@antoyo
Copy link
Contributor Author

antoyo commented Feb 26, 2025

Yes, that seems correct to me.

@antoyo
Copy link
Contributor Author

antoyo commented Mar 8, 2025

Fixed by #639.

@antoyo antoyo closed this as completed Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants