Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion / request: Adding predefined date patterns #1

Open
5toliv opened this issue Nov 6, 2020 · 11 comments
Open

Suggestion / request: Adding predefined date patterns #1

5toliv opened this issue Nov 6, 2020 · 11 comments

Comments

@5toliv
Copy link

5toliv commented Nov 6, 2020

Hi @ryanjamurphy ! All right?

Your plugin is fantastic! It addresses a need for students to maintain a continuous and effective flow of reviews. I am grateful for this!

I have a suggestion / request:
For us exam students, the reviews already have defined periods.
Ex.:
High incidence subjects: 3 - 20 - 45 - 60 days; and
Low incidence subjects: 4 - 30 - 60 - 90 days.

Would it be possible to add some template or configuration to make it possible to include revisions for previously defined days?

Thus, there would be no concern in defining date by date.

Exemple:
image

#enhancement

@ryanjamurphy
Copy link
Owner

Great suggestion, thanks! This would also be valuable for e.g., repeating tasks.

I'd love to implement it, and I think it should be easy. I will see what I can do.

@5toliv
Copy link
Author

5toliv commented Nov 6, 2020

Great suggestion, thanks! This would also be valuable for e.g., repeating tasks.

I'd love to implement it, and I think it should be easy. I will see what I can do.

This would be fantastic!

From now on, my many thanks!

@5toliv
Copy link
Author

5toliv commented Nov 6, 2020

Hi @ryanjamurphy ! All right?

Your plugin is fantastic! It addresses a need for students to maintain a continuous and effective flow of reviews. I am grateful for this!

I have a suggestion / request:
For us exam students, the reviews already have defined periods.
Ex.:
High incidence subjects: 3 - 20 - 45 - 60 days; and
Low incidence subjects: 4 - 30 - 60 - 90 days.

Would it be possible to add some template or configuration to make it possible to include revisions for previously defined days?

Thus, there would be no concern in defining date by date.

#enhancement

image

@ryanjamurphy
Copy link
Owner

Thanks for this. I think I'd go simpler, though. A syntax like:

Review pattern Pattern
high incidence 1 3 5 10 20 40

where each numeral indicates the number of days to add to today to add a review note.

Mostly because this'd be far easier to code, heh.

@5toliv
Copy link
Author

5toliv commented Nov 7, 2020

Much more direct and practical! Hahaha
Grateful for the attention and response!

@Nebucatnetzer
Copy link

I was just thinking about a custom default date. E.g. Monday because the default tomorrow doesn't actually work.
Maybe the two ideas are related?

@ryanjamurphy
Copy link
Owner

ryanjamurphy commented Nov 10, 2020

I was just thinking about a custom default date. E.g. Monday because the default tomorrow doesn't actually work.
Maybe the two ideas are related?

@Nebucatnetzer Do you mean for this plugin (Review), or for the Natural Language Dates plugin?

If you mean for Review, how do you imagine this would work? A "default review" command, maybe, such that instead of prompting with a modal it just assigns the current note to a preset number of days in the future or the past?

@Nebucatnetzer
Copy link

For this plugin.
I thought it might work like this:

  1. Configure a default date in the settings e.g. "monday".
  2. Go to a note.
  3. Start the review command.
  4. Don't enter anything and press enter.
  5. Review then uses the default date from the settings.

If the user enters something in the input field Review then uses the date from the input.

@ryanjamurphy
Copy link
Owner

Ah, neat. Makes sense to me—I'mma try to convert this into a new issue though, to keep things atomic!

@ryanjamurphy ryanjamurphy changed the title Suggestion / request: Adding predefined dates Suggestion / request: Adding predefined date patterns Nov 16, 2020
@ryanjamurphy
Copy link
Owner

Just a quick update on this front. What I need to figure out is how to easily and elegantly allow the user to add and remove an arbitrary number of patterns.

This is a bit tricky, because each new pattern would, ideally, also be a new in-app command (so that you don't need to jump through multiple modals or something to invoke a new pattern.

It should be doable, I just haven't had the chance to figure it out yet!

@codey-badger
Copy link

@5toliv hi, did you find a workaround in the mean time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants