Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move configure-time checks for OSX/XCode compatibility to a separate macro #25208

Closed
embray opened this issue Apr 18, 2018 · 10 comments
Closed

Move configure-time checks for OSX/XCode compatibility to a separate macro #25208

embray opened this issue Apr 18, 2018 · 10 comments
Labels
c: build: configure p: major / 3
Milestone
sage-8.4

Comments

@embray
Copy link
Contributor

embray commented Apr 18, 2018

Just a little further configure.ac cleanup. This is a big chunk of code that deserves to be centralized in one place if/when further updates to it are needed.

Depends on #25118

CC: @dimpase

Component: build: configure

Author: Erik Bray

Branch/Commit: 13619ff

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/25208
@embray embray added this to the sage-8.3 milestone Apr 18, 2018
@embray
Copy link
Contributor Author

embray commented Apr 18, 2018

Dependencies: #25118

@embray
Copy link
Contributor Author

embray commented Jul 13, 2018

comment:2

Forgot about this one.

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@fchapoton
Copy link
Contributor

comment:3

looks innocent enough..

@embray
Copy link
Contributor Author

embray commented Jul 16, 2018

comment:4

Yes, it's just a verbatim code move--no changes otherwise. I'm trying to make the configure.ac shorter and easier to read.

@dimpase
Copy link
Member

dimpase commented Jul 16, 2018

comment:5

let me test this on OSX...

@dimpase
Copy link
Member

dimpase commented Jul 17, 2018

comment:6

OK, it's fine.

@embray
Copy link
Contributor Author

embray commented Jul 17, 2018

comment:7

Replying to @dimpase:

OK, it's fine.

Thanks!

@embray
Copy link
Contributor Author

embray commented Jul 18, 2018

comment:8

I believe this issue can reasonably be addressed for Sage 8.4.

@embray embray modified the milestones: sage-8.3, sage-8.4 Jul 18, 2018
@vbraun
Copy link
Member

vbraun commented Aug 5, 2018

Changed branch from u/embray/build-configure/darwin-macro to 13619ff

@vbraun vbraun closed this as completed in 76e7245 Aug 5, 2018
@embray embray mentioned this issue Feb 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build: configure p: major / 3
Projects
None yet
Milestone
sage-8.4
Development

No branches or pull requests
4 participants
@embray @vbraun @dimpase @fchapoton