spkg-configure.m4 for lcalc

[dimpase]

Debian and Fedora package lcalc (Fedora calls the package L-function-devel). On Debian one needs packages liblfunction-dev and lcalc.

One needs to check how well-patched they are.

We had to introduce an env. var. SAGE_LCALC_INCDIR_NOLIBPREFIX to deal with the discrepancy in the include names, which is libLfunction/ on sage-dist, but Lfunction/ on Debian.

if SAGE_LCALC_INCDIR_NOLIBPREFIX is not '' then we assume that
the include prefix is Lfunction/, and otherwise it is
libLfunction/.

CC: @embray @isuruf @antonio-rojas @kiwifb

Component: build: configure

Author: Dima Pasechnik

Branch: 6aa7e76

Reviewer: Isuru Fernando

Issue created by migration from https://trac.sagemath.org/ticket/28224

[dimpase]

comment:1

Does Conda provide lcalc?

[isuruf]

comment:2

Replying to @dimpase:

Does Conda provide lcalc?

Yes and uses the patches from sage https://github.com/conda-forge/lcalc-feedstock/tree/master/recipe/patches

[dimpase]

comment:3

lcalc depends on PARI, so we need to deal with pari first.

[dimpase]

Dependencies: #28242

[dimpase]

New commits:

311fce3

spkg-configure for lcalc

[dimpase]

Branch: u/dimpase/packages/lcalcconf

[dimpase]

Author: Dima Pasechnik

[dimpase]

Commit: 311fce3

[isuruf]

comment:6

sage-dist, conda, arch installs the header as <prefix>/include/libLfunction/L.h while debian installs it as <prefix>/include/Lfunction/L.h.

You'll need more changes to make lcalc work with Debian way. For eg: https://github.com/sagemath/sage-prod/blob/master/src/sage/libs/lcalc/lcalc_sage.h#L1

[dimpase]

comment:7

oops, right, one would in the very least deal with hardcoded

src/sage/libs/lcalc/lcalc_sage.h:#include "libLfunction/L.h"

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

dbcf506

spkg-configure for lcalc

[sagetrac-git]

Changed commit from 311fce3 to dbcf506

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

36c5fca

spkg-configure for lcalc

[sagetrac-git]

Changed commit from dbcf506 to 36c5fca

[dimpase]

comment:10

OK, so the updated branch works with Debian's lcalc, currently checking with sage-dist's lcalc.
Any chance to test this with Conda? Thanks!

[isuruf]

comment:11

Works for me on conda. I see that you have test x$ac_cv_header_libLfunction = x. Isn't that supposed to be test x$ac_cv_header_libLfunction_L_h = x ?

[sagetrac-git]

Changed commit from 36c5fca to 093f706

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

093f706

typo - with it the test was always passing

[dimpase]

comment:13

good catch. I guess you won't be able to build lcalc cython extension without the latest commit...

[dimpase]

comment:33

reworded the last commit message, no code changes.

[dimpase]

Changed dependencies from #28242 to none

[kiwifb]

comment:35

I avoided this ticket so far because lcalc is one of those packages that "smells" and may be better left alone.

For the record sage-on-gentoo installs headers in Lfunction which is closer to the original upstream than what libLfunction is. The latter being a sage packaging special.
https://github.com/sagemath/sagetrac-mirror/blob/master/build/pkgs/lcalc/patches/Makefile.patch#L231
being replaced by
https://github.com/sagemath/sagetrac-mirror/blob/master/build/pkgs/lcalc/patches/Makefile.patch#L234

[isuruf]

comment:36

Shall we change the default and also the patch to use Lfunction then?

I can change it in conda.

[kiwifb]

comment:37

Being uniform about these headers locations in distributions and sage certainly would help.

[dimpase]

comment:38

Right. I just checked that on Fedora it's Lfunction too.
I've asked on sage-devel about the reason for these naming twists...
https://groups.google.com/d/msg/sage-devel/fAPWh1G8_Qw/xMAmtUapAQAJ

[dimpase]

comment:39

I've changed the branch so that INCDIR of libLfunction is Lfunction/.

this is much simpler, please review.

---

New commits:

ec86516	Updated [SageMath](../wiki/SageMath) version to 8.9.beta8
567d9a0	spkg-configure.m4 for lcalc, and INCDIR rename

[dimpase]

Changed branch from u/dimpase/packages/lcalcconf to u/dimpase/packages/lcalcchangeinclude

[dimpase]

Changed commit from 80bef09 to 567d9a0

[isuruf]

comment:40

Needs a version bump for lcalc

[sagetrac-git]

Changed commit from 567d9a0 to 6aa7e76

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

6aa7e76

lcalc version bump due to moved INCDIR

[kiwifb]

comment:43

Love the fact that I won't have to patch that little bit anymore - I am sure my colleagues in other distros are happy about that too.

[vbraun]

Changed branch from u/dimpase/packages/lcalcchangeinclude to 6aa7e76

[thierry-FreeBSD]

comment:45

FYI, a more recent snapshot, for version 1.3, is available at https://github.com/agrawroh/l-calc .
It has been exported from code.google.com/p/l-calc.

[thierry-FreeBSD]

Changed commit from 6aa7e76 to none