-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spkg-configure for cbc #28908
Comments
This comment has been minimized.
This comment has been minimized.
Author: Matthias Koeppe |
Dependencies: #28175 |
Commit: |
comment:3
Sage's cbc lists quite a few dependencies (readline zlib bzip2 $(BLAS)) , but none are checked by spkg-configure, whereas they are really there, as may be seen on Debian by running
It seems that cbc.pc file is lacking in this sense (along with its dependencies, it seems they don't bother with anything that is external to , they really should list them - should it be reported to upstream? Anyhow, we should write these deps out, as it's done in e.g. gsl's ticket #28879 SAGE_SPKG_CONFIGURE([cbc], [
SAGE_SPKG_DEPCHECK([atlas openblas zlib bzip2], [
dnl checking with pkg-config
PKG_CHECK_MODULES([CBC], [cbc >= 2.9.4], [], [sage_spkg_install_cbc=yes])
])
]) Perhaps we should update the copy of cbc.pc, to include all these deps New commits:
|
comment:4
Replying to @dimpase:
I'm sure they'd like to know, please go ahead.
Thanks, I'll wait with that until #27870 to be merged. |
comment:5
I guess their rationale for dependencies in *.pc files is that they don't assume that I've listed this ticket in #27330. By the way, to move #27870 forward please review its dependence, #28883 |
comment:8
looks good to me |
Reviewer: Dima Pasechnik |
Changed branch from u/mkoeppe/28908_spkg_configure_cbc to |
We add
spkg-configure
for the optional packagecbc
.Because
OptionalExtension
does not know about packages found by spkg-configure (see #25828), this is only useful on top of #28175.Depends on #28175
Depends on #27870
CC: @dimpase
Component: packages: optional
Author: Matthias Koeppe
Branch/Commit:
2b07cf5
Reviewer: Dima Pasechnik
Issue created by migration from https://trac.sagemath.org/ticket/28908
The text was updated successfully, but these errors were encountered: