Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spkg-configure for cbc #28908

Closed
mkoeppe opened this issue Dec 25, 2019 · 14 comments
Closed

spkg-configure for cbc #28908

mkoeppe opened this issue Dec 25, 2019 · 14 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 25, 2019

We add spkg-configure for the optional package cbc.

Because OptionalExtension does not know about packages found by spkg-configure (see #25828), this is only useful on top of #28175.

Depends on #28175
Depends on #27870

CC: @dimpase

Component: packages: optional

Author: Matthias Koeppe

Branch/Commit: 2b07cf5

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/28908

@mkoeppe mkoeppe added this to the sage-9.0 milestone Dec 25, 2019
@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 25, 2019

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 25, 2019

Dependencies: #28175

@mkoeppe mkoeppe modified the milestones: sage-9.0, sage-9.1 Dec 25, 2019
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 25, 2019

Branch: u/mkoeppe/28908_spkg_configure_cbc

@dimpase
Copy link
Member

dimpase commented Dec 26, 2019

Commit: 0e5b5b1

@dimpase
Copy link
Member

dimpase commented Dec 26, 2019

comment:3

Sage's cbc lists quite a few dependencies (readline zlib bzip2 $(BLAS)) , but none are checked by spkg-configure, whereas they are really there, as may be seen on Debian by running

ldd /usr/lib/x86_64-linux-gnu/libCbc.so.3

It seems that cbc.pc file is lacking in this sense (along with its dependencies, it seems they don't bother with anything that is external to , they really should list them - should it be reported to upstream?

Anyhow, we should write these deps out, as it's done in e.g. gsl's ticket #28879

SAGE_SPKG_CONFIGURE([cbc], [
  SAGE_SPKG_DEPCHECK([atlas openblas zlib bzip2], [
    dnl  checking with pkg-config
    PKG_CHECK_MODULES([CBC], [cbc >= 2.9.4], [], [sage_spkg_install_cbc=yes])
  ])
])

Perhaps we should update the copy of cbc.pc, to include all these deps
(more precisely, all but altlas) in the Requires: field.


New commits:

86c7da7Add packages sage_numerical_backends_*
437fec5Fixup dependencies
846ca9aReplace CoinBackend, CPLEXBackend, GurobiBackend by their versions imported from sage_numerical_backends_*
3c557b4build/pkgs/sage_numerical_backends_*/spkg-install: Adjust error message
84c83f2src/doc/en/thematic_tutorials/linear_programming.rst: Update COIN/CPLEX/Gurobi install instructions
4828766MixedIntegerLinearProgram: Update docstrings for class and `__init__`, refer to thematic tutorial, and reduce copy-paste
189d60bget_solver: Reduce copy-paste in docstring
357e966src/doc/en/thematic_tutorials/linear_programming.rst: Update license info, URL for cbc
0e5b5b1build/pkgs/cbc/spkg-configure.m4: New

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 27, 2019

Changed dependencies from #28175 to #28175, #27870

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 27, 2019

comment:4

Replying to @dimpase:

Sage's cbc lists quite a few dependencies (readline zlib bzip2 $(BLAS)) , but none are checked by spkg-configure ...
It seems that cbc.pc file is lacking in this sense (along with its dependencies, it seems they don't bother with anything that is external to , they really should list them - should it be reported to upstream?

I'm sure they'd like to know, please go ahead.

Anyhow, we should write these deps out, as it's done in e.g. gsl's ticket #28879

SAGE_SPKG_CONFIGURE([cbc], [
  SAGE_SPKG_DEPCHECK([atlas openblas readline zlib bzip2], [
    dnl  checking with pkg-config
    PKG_CHECK_MODULES([CBC], [cbc >= 2.9.4], [], [sage_spkg_install_cbc=yes])
  ])
])

Thanks, I'll wait with that until #27870 to be merged.

@dimpase
Copy link
Member

dimpase commented Dec 27, 2019

comment:5

I guess their rationale for dependencies in *.pc files is that they don't assume that
blas lapack zlib bzip2 (I scratched readline out, it's actually not a dependence)
have *.pc files. Which is fair enough.

I've listed this ticket in #27330.

By the way, to move #27870 forward please review its dependence, #28883

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 11, 2020

Changed commit from 0e5b5b1 to 2b07cf5

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 11, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

cb85af7build/pkgs/cbc/spkg-configure.m4: New
2b07cf5build/pkgs/cbc/spkg-configure.m4: Add SAGE_SPKG_DEPCHECK

@dimpase
Copy link
Member

dimpase commented Jan 11, 2020

comment:8

looks good to me

@dimpase
Copy link
Member

dimpase commented Jan 11, 2020

Reviewer: Dima Pasechnik

@vbraun
Copy link
Member

vbraun commented Jan 18, 2020

Changed branch from u/mkoeppe/28908_spkg_configure_cbc to 2b07cf5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants