Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spkg-configure.m4 for planarity #29063

Closed
dimpase opened this issue Jan 21, 2020 · 9 comments
Closed

spkg-configure.m4 for planarity #29063

dimpase opened this issue Jan 21, 2020 · 9 comments

Comments

@dimpase
Copy link
Member

dimpase commented Jan 21, 2020

this is a relatively stable C library, the only problem is that there are also very old versions (2.2.0 on Fedora 26) around, and it's not quite clear whether they work and how to distinguish them.

We do the latter by checking for link member in vertexRec from planarity/graphStructures.h

CC: @kiwifb @embray @tobihan @infinity0 @isuruf @mkoeppe

Component: build: configure

Author: Dima Pasechnik

Branch/Commit: 604dfac

Reviewer: Isuru Fernando

Issue created by migration from https://trac.sagemath.org/ticket/29063

@dimpase dimpase added this to the sage-9.1 milestone Jan 21, 2020
@dimpase
Copy link
Member Author

dimpase commented Jan 21, 2020

comment:1

package names:

planarity libplanarity-dev (Debian)

planarity planarity-devel (Fedora)

@dimpase
Copy link
Member Author

dimpase commented Jan 21, 2020

Author: Dima Pasechnik

@dimpase
Copy link
Member Author

dimpase commented Jan 21, 2020

comment:2

2.2.0 prevents sagelib building, as planarity/graphStructures.h should have

typedef struct
{
        int  link[2];
        int  index;
        unsigned flags;
} vertexRec;

and not

typedef struct
{
        int DFSParent, leastAncestor, Lowpoint, adjacentTo;
        int pertinentBicompList, separatedDFSChildList, fwdArcList;
} vertexRec;

So we can write a test using AC_COMPILE_IFELSE().

@dimpase
Copy link
Member Author

dimpase commented Jan 21, 2020

Branch: u/dimpase/packages/planarity-config

@dimpase
Copy link
Member Author

dimpase commented Jan 21, 2020

Commit: 604dfac

@dimpase

This comment has been minimized.

@dimpase
Copy link
Member Author

dimpase commented Jan 21, 2020

New commits:

604dfacspkg-configure.m4 for planarity

@isuruf
Copy link
Member

isuruf commented Jan 22, 2020

Reviewer: Isuru Fernando

@vbraun
Copy link
Member

vbraun commented Jan 25, 2020

Changed branch from u/dimpase/packages/planarity-config to 604dfac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants