sage-spkg: Add an option -w for warning only if spkg-check fails

[mkoeppe]

In addition, setting SAGE_CHECK=warn has the same effect.

This is useful for automated builds - using make -k SAGE_CHECK=warn we can collect many build and test suite results in one shot.

CC: @dimpase @jhpalmieri

Component: build

Author: Matthias Koeppe

Branch/Commit: f45b28d

Reviewer: Dima Pasechnik, John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/29301

[mkoeppe]

Branch: u/mkoeppe/sage_spkg__add_an_option__w_for_warning_only_if_spkg_check_fails

[mkoeppe]

Commit: 46a220e

[mkoeppe]

New commits:

46a220e

Implement SAGE_CHECK=warn, sage-spkg -w

[mkoeppe]

Author: Matthias Koeppe

[jhpalmieri]

comment:4

If you set SAGE_CHECK=warn, it doesn't behave just like passing the -w flag to sage-spkg: the latter sets SAGE_CHECK_PACKAGES=x, while the former does not. Therefore the default setting SAGE_CHECK_PACKAGES='!python2,!python3' gets used with the former.

What is the intent?

(Aside: should flags like -c and now -w also have corresponding Makefile targets? We shouldn't have to set environment variables to do this.)

[mkoeppe]

comment:5

Replying to @jhpalmieri:

If you set SAGE_CHECK=warn, it doesn't behave just like passing the -w flag to sage-spkg: the latter sets SAGE_CHECK_PACKAGES=x, while the former does not. Therefore the default setting SAGE_CHECK_PACKAGES='!python2,!python3' gets used with the former.

What is the intent?

I set SAGE_CHECK=warn to enable this behavior as a default for all packages. I don't see why the default SAGE_CHECK_PACKAGES='!python2,!python3' should not apply. In my test scripts, I set SAGE_CHECK_PACKAGES to more exclusions (for example, ppl has a testsuite that takes very long.)

(Aside: should flags like -c and now -w also have corresponding Makefile targets? We shouldn't have to set environment variables to do this.)

Makefile targets, I don't think. We could make it configure options though. (In some follow-up ticket.)

[jhpalmieri]

comment:7

I think that if SAGE_CHECK=warn and if SAGE_CHECK_PACKAGES is empty, then everything should be tested, even Python. (The reason for skipping Python is not because it takes a long time, but rather to avoid make stopping when Python's tests fail.) Otherwise, do I need to set SAGE_CHECK_PACKAGES to some artificial setting to test all packages, including Python?

If SAGE_CHECK_PACKAGES is not empty, then setting SAGE_CHECK=warn should not affect that.

Re Makefile targets vs. configure: it feels more standard to have make check or similar, rather than have it be a configure option. Not to be done on this ticket, either way.

[sagetrac-git]

Changed commit from 46a220e to f45b28d

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

f45b28d

If SAGE_CHECK=warn, do not exclude python by default via SAGE_CHECK_PACKAGES

[mkoeppe]

comment:9

Is this doing what you have in mind?

[jhpalmieri]

comment:10

At first glance it looks good, but I have to test it. Ideally if I run make with SAGE_CHECK=warn, then there would be summary information at the end. ("The build succeeded but the following packages failed their test suites: ...") Any ideas how to do that?

[mkoeppe]

comment:11

Well, the code for the summary "The following package(s) may have failed to build..." is currently only run on failure.
I suppose we could run it on success too if SAGE_CHECK=warn...

[dimpase]

comment:12

OK, seems to work

[dimpase]

Reviewer: Dima Pasechnik, John Palmieri

[mkoeppe]

comment:13

Thanks! Further refinements can be done on a follow-up ticket.

[jhpalmieri]

comment:14

Followup at #29402.

[vbraun]

Changed branch from u/mkoeppe/sage_spkg__add_an_option__w_for_warning_only_if_spkg_check_fails to f45b28d