spkg-configure.m4 for flintqs

[orlitzky]

This package only installs the QuadraticSieve executable, which needs to be in the PATH for qsieve() to work in Sage.

CC: @dimpase @embray @mkoeppe @kiwifb

Component: build: configure

Author: Michael Orlitzky

Branch/Commit: 5990654

Reviewer: Matthias Koeppe, Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/29430

[orlitzky]

Branch: u/mjo/ticket/29430

[orlitzky]

New commits:

580c0ee

Trac #29430: new spkg-configure.m4 for flintqs.

[orlitzky]

Commit: 580c0ee

[mkoeppe]

comment:2

Needs distros/

[sagetrac-git]

Changed commit from 580c0ee to 2b1e41b

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

2b1e41b

Trac #29430: add distros/* information for flintqs.

[orlitzky]

comment:4

I added debian, fedora, and gentoo (I added the Gentoo package a few seconds before opening this ticket) based on repology.org results. Ubuntu and nix have packages too, but I don't see ubuntu.txt or nix.txt anywhere in the tree.

[mkoeppe]

comment:5

ubuntu uses debian.txt

[mkoeppe]

comment:6

See #29130 for nix

[mkoeppe]

comment:7

Have you checked arch?

[dimpase]

comment:8

on conda it's flintqs too.

[dimpase]

comment:9

and on arch, cf https://www.archlinux.org/packages/community/x86_64/flintqs/

[dimpase]

comment:10

Fedora does not have flintqs

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

b343351

Trac #29430: add distros/* information for flintqs.

[sagetrac-git]

Changed commit from 2b1e41b to b343351

[orlitzky]

comment:12

Force pushed a rename fedora -> conda. The arch.txt was already there (before I added the m4 file).

[dimpase]

Reviewer: Matthias Koeppe, Dima Pasechnik

[dimpase]

comment:13

lgtm - but add author's name

[orlitzky]

Author: Michael Orlitzky

[orlitzky]

comment:18

Sorry, I'll have to add "mpir" to the DEPCHECK here. I didn't realize sage installed it in place of gmp with everything renamed mpir->gmp.

[dimpase]

comment:19

you need to check for BOTH gmp and mpir, not just one of them.

[dimpase]

comment:20

e.g.

SAGE_SPKG_CONFIGURE([givaro], [
    m4_pushdef([SAGE_GIVARO_MINVER],["40101"])
    SAGE_SPKG_DEPCHECK([gmp mpir], [
...

[orlitzky]

comment:21

Thanks, I see that now. I was rather confused about how all these packages explicitly looking for libgmp in ./configure could use MPIR in sage. I'm halfway through a build test for a ppl spkg-configure but as soon as it finishes I'll fix this up.

[dimpase]

Changed commit from b343351 to 1fdea6a

[dimpase]

comment:22

added this fix, rebased over latest beta

---

New commits:

6311b9c	Trac #29430: new spkg-configure.m4 for flintqs.
db57b3f	Trac #29430: add distros/* information for flintqs.
1fdea6a	adding mpir into deps

[dimpase]

Changed branch from u/mjo/ticket/29430 to public/packages/flintqs-config

[dimpase]

comment:23

lgtm

[mkoeppe]

comment:24

If this only installs an executable, I don't think we need any depcheck at all because there cannot be a library conflict.

[orlitzky]

comment:26

The QuadraticSieve executable is the only thing used, and if it exists on the system, it should work fine.. does anyone philosophically object if --without-system-gmp (or mpir) is ignored for some packages?

[mkoeppe]

comment:27

Replying to @orlitzky:

does anyone philosophically object if --without-system-gmp (or mpir) is ignored for some packages?

I don't think this is a concern.

[orlitzky]

Changed branch from public/packages/flintqs-config to u/mjo/ticket/29430

[orlitzky]

Changed commit from 1fdea6a to 5990654

[orlitzky]

comment:28

Ok, depcheck is gone.

---

New commits:

34a9dbf	Trac #29430: new spkg-configure.m4 for flintqs.
5990654	Trac #29430: add distros/* information for flintqs.

[vbraun]

Changed branch from u/mjo/ticket/29430 to 5990654