Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spkg-configure.m4 for libbraiding #29458

Closed
orlitzky opened this issue Apr 3, 2020 · 12 comments
Closed

spkg-configure.m4 for libbraiding #29458

orlitzky opened this issue Apr 3, 2020 · 12 comments
Labels
c: build: configure p: major / 3 t: enhancement
Milestone
sage-9.1

Comments

@orlitzky
Copy link
Contributor

orlitzky commented Apr 3, 2020

Since this is a C++ library, we'll have to compile and run a test program to detect it.

CC: @dimpase @embray @kiwifb @mkoeppe @isuruf

Component: build: configure

Author: Michael Orlitzky

Branch/Commit: d7a6cdd

Reviewer: Isuru Fernando

Issue created by migration from https://trac.sagemath.org/ticket/29458
@orlitzky orlitzky added this to the sage-9.1 milestone Apr 3, 2020
@orlitzky
Copy link
Contributor Author

orlitzky commented Apr 3, 2020

New commits:

f59b0f3Trac #29458: new spkg-configure.m4 for libbraiding.
e6bc87cTrac #29458: add more distros/* information for libbraiding.

@orlitzky
Copy link
Contributor Author

orlitzky commented Apr 3, 2020

Branch: u/mjo/ticket/29458

@orlitzky
Copy link
Contributor Author

orlitzky commented Apr 3, 2020

Commit: e6bc87c

@dimpase
Copy link
Member

dimpase commented Apr 3, 2020

comment:2

debian package is called libbraiding-dev, please fix its name.

@isuruf
Copy link
Member

isuruf commented Apr 3, 2020

comment:3

Looks good to me. Can you add libbraiding conda package too?

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 3, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

d7a6cddTrac #29458: add more distros/* information for libbraiding.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 3, 2020

Changed commit from e6bc87c to d7a6cdd

@orlitzky
Copy link
Contributor Author

orlitzky commented Apr 3, 2020

comment:5

fixed and fixed

@isuruf
Copy link
Member

isuruf commented Apr 4, 2020

Reviewer: Isuru Fernando

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 4, 2020

comment:7

author name

@orlitzky
Copy link
Contributor Author

orlitzky commented Apr 4, 2020

Author: Michael Orlitzky

@vbraun
Copy link
Member

vbraun commented Apr 9, 2020

Changed branch from u/mjo/ticket/29458 to d7a6cdd

@vbraun vbraun closed this as completed in 7327296 Apr 9, 2020
@embray embray mentioned this issue Jan 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build: configure p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.1
Development

No branches or pull requests
5 participants
@vbraun @dimpase @orlitzky @isuruf @mkoeppe