Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

time step overflow happend in to_note_representation #8

Closed
TwinMooon opened this issue Oct 23, 2020 · 1 comment
Closed

time step overflow happend in to_note_representation #8

TwinMooon opened this issue Oct 23, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@TwinMooon
Copy link

In the muspy.classes.note.py
In line 56-59, array = np.zeros((len(notes), 4), np.uint8)
However, for long pieces, the time step will greater than 255, then overflow will happen.
@salu133445
Copy link
Owner

Thanks for reporting. This has been fixed in 0f92edd. The data type now defaults to int rather than uint8.

@salu133445 salu133445 added the bug Something isn't working label Nov 6, 2020
@salu133445 salu133445 mentioned this issue Dec 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@salu133445 @TwinMooon