Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add features to review completed matches and resume unfinished ones #340

Open
odrail opened this issue Mar 6, 2025 · 6 comments · May be fixed by #339
Open

Add features to review completed matches and resume unfinished ones #340

odrail opened this issue Mar 6, 2025 · 6 comments · May be fixed by #339

Comments

@odrail
Copy link
Contributor

odrail commented Mar 6, 2025

In PR #339, I am working on the following features:

  • Reviewing completed previous matches
  • Resuming incomplete matches

I hope these enhancements will be useful.

@odrail odrail linked a pull request Mar 6, 2025 that will close this issue
@samimsu
Copy link
Owner

samimsu commented Mar 6, 2025

Ideally the code changes should be minimal so it's easier to review and there aren't unforeseen consequences in other places.

I noticed this issue when I switch between levels. It seems like some sort of layout shift.

screen-20250307-024010.mp4

I would ideally like to poll people on whether they would like this feature and then decide to incorporate it. If that's not possible then I'll make a call on it.

@odrail
Copy link
Contributor Author

odrail commented Mar 6, 2025

The issue you're seeing is due to a board redraw problem. I'm aware of this bug and will commit the fix shortly.

@odrail
Copy link
Contributor Author

odrail commented Mar 6, 2025

I noticed this issue when I switch between levels. It seems like some sort of layout shift.

Try now

@samimsu
Copy link
Owner

samimsu commented Mar 6, 2025

It's fixed

@odrail
Copy link
Contributor Author

odrail commented Mar 10, 2025

The PR is ready for review

@samimsu
Copy link
Owner

samimsu commented Mar 10, 2025

Hey thanks. I'm still deciding on whether this feature is beneficial for users. I think typically in games when you come back to a level it starts from scratch. I've taken feedback from one user who wouldn't want this feature. I want to get feedback from more people before adding this. I appreciate the effort so I'd feel bad if it went to waste but I hope you can understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants