Skip to content

Commit 94f8343

Browse files
committed
Merge pull request #246 from sbt/wip/bash-jvm-options
FIX #211 and #232. Checking $java_args[@] for memory settings, too.
2 parents 6703ba2 + 4391fbc commit 94f8343

File tree

1 file changed

+12
-2
lines changed
  • src/main/resources/com/typesafe/sbt/packager/archetypes

1 file changed

+12
-2
lines changed

src/main/resources/com/typesafe/sbt/packager/archetypes/bash-template

+12-2
Original file line numberDiff line numberDiff line change
@@ -156,8 +156,17 @@ get_mem_opts () {
156156

157157
# if we detect any of these settings in ${java_opts} we need to NOT output our settings.
158158
# The reason is the Xms/Xmx, if they don't line up, cause errors.
159-
if [[ "${java_opts}" == *-Xmx* ]] || [[ "${java_opts}" == *-Xms* ]] || [[ "${java_opts}" == *-XX:MaxPermSize* ]] || [[ "${java_opts}" == *-XX:ReservedCodeCacheSize* ]]; then
160-
echo ""
159+
if [[ "${java_opts}" == *-Xmx* ]] ||
160+
[[ "${java_opts}" == *-Xms* ]] ||
161+
[[ "${java_opts}" == *-XX:MaxPermSize* ]] ||
162+
[[ "${java_opts}" == *-XX:ReservedCodeCacheSize* ]] ||
163+
# check java arguments for settings, too
164+
[[ "${java_args[@]}" == *-Xmx* ]] ||
165+
[[ "${java_args[@]}" == *-Xms* ]] ||
166+
[[ "${java_args[@]}" == *-XX:MaxPermSize* ]] ||
167+
[[ "${java_args[@]}" == *-XX:ReservedCodeCacheSize* ]];
168+
then
169+
echo ""
161170
elif [[ !$no_java_version_check ]] && [[ java_version > "1.8" ]]; then
162171
echo "-Xms${mem}m -Xmx${mem}m -XX:ReservedCodeCacheSize=${codecache}m"
163172
else
@@ -332,6 +341,7 @@ EOM
332341
### Main script ###
333342
### ------------------------------- ###
334343

344+
declare debug=0
335345
declare -a residual_args
336346
declare -a java_args
337347
declare -a app_commands

0 commit comments

Comments
 (0)