Skip to content

Commit 9fb55c7

Browse files
committed
Merge pull request #749 from vsuharnikov/update-docker-spotify
Updates version of DockerSpotifyClient to 3.5.13 and fixes NullPointerException
2 parents 3c161c8 + 8f1fd78 commit 9fb55c7

File tree

5 files changed

+8
-8
lines changed

5 files changed

+8
-8
lines changed

build.sbt

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ libraryDependencies ++= Seq(
1111
// for jdkpackager
1212
"org.apache.ant" % "ant" % "1.9.6",
1313
// these dependencies have to be explicitly added by the user
14-
"com.spotify" % "docker-client" % "3.2.1" % "provided",
14+
"com.spotify" % "docker-client" % "3.5.13" % "provided",
1515
"org.vafer" % "jdeb" % "1.3" % "provided" artifacts (Artifact("jdeb", "jar", "jar")),
1616
"org.scalatest" %% "scalatest" % "2.2.4" % "test"
1717
)

src/main/scala/com/typesafe/sbt/packager/docker/DockerSpotifyClientPlugin.scala

+4-4
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import java.nio.file.Paths
66

77
import com.spotify.docker.client.messages.ProgressMessage
88
import com.spotify.docker.client.{ ProgressHandler, DockerClient, DefaultDockerClient }
9-
import com.spotify.docker.client.DockerClient.BuildParameter._
9+
import com.spotify.docker.client.DockerClient.BuildParam
1010
import sbt._
1111
import sbt.Keys._
1212
import packager.Keys._
@@ -42,7 +42,7 @@ import universal.UniversalPlugin.autoImport.stage
4242
* and add the dependency in your `plugins.sbt`
4343
*
4444
* {{{
45-
* libraryDependencies += "com.spotify" % "docker-client" % "3.2.1"
45+
* libraryDependencies += "com.spotify" % "docker-client" % "3.5.13"
4646
* }}}
4747
*
4848
* The Docker-spotify client is a provided dependency so you have to add it on your own.
@@ -77,10 +77,10 @@ object DockerSpotifyClientPlugin extends AutoPlugin {
7777
def progress(message: ProgressMessage) = {
7878
Option(message.error()) match {
7979
case Some(error) if error.nonEmpty => log.error(message.error())
80-
case _ => log.info(message.stream())
80+
case _ => Option(message.stream()) foreach (v => log.info(v))
8181
}
8282
}
83-
}, FORCE_RM)
83+
}, BuildParam.forceRm())
8484

8585
if (latest) {
8686
val name = tag.substring(0, tag.lastIndexOf(":")) + ":latest"
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
addSbtPlugin("com.typesafe.sbt" % "sbt-native-packager" % sys.props("project.version"))
22

33
// needs to be added for the docker spotify client
4-
libraryDependencies += "com.spotify" % "docker-client" % "3.2.1"
4+
libraryDependencies += "com.spotify" % "docker-client" % "3.5.13"

src/sphinx/formats/docker.rst

+1-1
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ and this to your ``plugins.sbt``
5353

5454
.. code-block:: scala
5555
56-
libraryDependencies += "com.spotify" % "docker-client" % "3.2.1"
56+
libraryDependencies += "com.spotify" % "docker-client" % "3.5.13"
5757
5858
The Docker-spotify client is a provided dependency so you have to add it on your own.
5959
It brings a lot of dependenciesthat could slow your build times. This is the reason

test-project-docker/project/plugins.sbt

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@ lazy val root = Project("plugins", file(".")).dependsOn(plugin)
33
lazy val plugin = file("../").getCanonicalFile.toURI
44

55
// needs to be added for the docker spotify client
6-
libraryDependencies += "com.spotify" % "docker-client" % "3.2.1"
6+
libraryDependencies += "com.spotify" % "docker-client" % "3.5.13"

0 commit comments

Comments
 (0)