Merge pull request #400 from sbt/fix/debian-lintian

FIX #391 Fixing all lintian errors and some warnings

Author: muuki88

src/main/resources/com/typesafe/sbt/packager/archetypes/java_server/systemloader/systemv/loader-functions

@@ -4,7 +4,7 @@
 #
 startService() {
     app_name=$1
-    if hash update-rc.d 2>/dev/null; then
+    if hash update-rc.d >/dev/null 2>&1; then
 	echo "Adding $app_name to autostart using update-rc.d"
 	update-rc.d $app_name defaults
 	service $app_name start
@@ -24,7 +24,7 @@ startService() {
 #
 stopService() {
     app_name=$1
-    if hash update-rc.d 2>/dev/null; then
+    if hash update-rc.d >/dev/null 2>&1; then
 	echo "Removing $app_name from autostart using update-rc.d"
 	update-rc.d -f $app_name remove
 	service $app_name stop

src/main/scala/com/typesafe/sbt/packager/archetypes/JavaServerApplication.scala

@@ -65,11 +65,6 @@ object JavaServerAppPackaging extends AutoPlugin {
     linuxPackageMappings <++= (makeEtcDefault, packageName in Linux) map { (conf, name) =>
       conf.map(c => LinuxPackageMapping(Seq(c -> ("/etc/default/" + name)),
         LinuxFileMetaData(Users.Root, Users.Root, "644")).withConfig()).toSeq
-    },
-
-    // === /var/run/app pid folder ===
-    linuxPackageMappings <+= (packageName in Linux, daemonUser in Linux, daemonGroup in Linux) map { (name, user, group) =>
-      packageTemplateMapping("/var/run/" + name)() withUser user withGroup group withPerms "755"
     }
 
   )
@@ -100,6 +95,9 @@ object JavaServerAppPackaging extends AutoPlugin {
         serverLoading in Debian) map makeStartScript,
       linuxPackageMappings <++= (packageName, linuxMakeStartScript, serverLoading, defaultLinuxStartScriptLocation) map startScriptMapping
     )) ++ Seq(
+      // === Daemon User and Group ===
+      daemonUser in Debian <<= daemonUser in Linux,
+      daemonGroup in Debian <<= daemonGroup in Linux,
       // === Maintainer scripts ===
       debianMakePreinstScript <<= (target in Universal, serverLoading in Debian, linuxScriptReplacements) map makeMaintainerScript(Preinst),
       debianMakePostinstScript <<= (target in Universal, serverLoading in Debian, linuxScriptReplacements) map makeMaintainerScript(Postinst),
@@ -117,8 +115,16 @@ object JavaServerAppPackaging extends AutoPlugin {
       requiredStopFacilities in Rpm <<= (serverLoading) apply defaultFacilities,
       linuxScriptReplacements <++= (requiredStartFacilities, requiredStopFacilities, startRunlevels, stopRunlevels, serverLoading) apply
         makeStartScriptReplacements,
-      linuxScriptReplacements += JavaServerLoaderScript.loaderFunctionsReplacement(serverLoading.value, ARCHETYPE)
+      linuxScriptReplacements += JavaServerLoaderScript.loaderFunctionsReplacement(serverLoading.value, ARCHETYPE),
+
+      // === /var/run/app pid folder ===
+      linuxPackageMappings <+= (packageName, daemonUser, daemonGroup) map { (name, user, group) =>
+        packageTemplateMapping("/var/run/" + name)() withUser user withGroup group withPerms "755"
+      }
     )) ++ Seq(
+      // === Daemon User and Group ===
+      daemonUser in Rpm <<= daemonUser in Linux,
+      daemonGroup in Rpm <<= daemonGroup in Linux,
       // === Startscript creation ===
       linuxStartScriptTemplate := JavaServerLoaderScript(
         script = startScriptName((serverLoading in Rpm).value, Rpm),

src/main/scala/com/typesafe/sbt/packager/debian/DebianPlugin.scala

@@ -212,7 +212,7 @@ object DebianPlugin extends AutoPlugin with DebianNativePackaging {
           t
         },
       // Replacement for ${{header}} as debian control scripts are bash scripts
-      linuxScriptReplacements += ("header" -> "#!/bin/sh\n")
+      linuxScriptReplacements += ("header" -> "#!/bin/sh\nset -e")
 
     // Adding package specific implementation settings
     ))

src/sbt-test/debian/daemon-user-deb/build.sbt

@@ -28,7 +28,6 @@ TaskKey[Unit]("check-control-files") <<= (target, streams) map { (target, out) =
   assert(postinst contains "addGroup daemongroup", "postinst misses addgroup for daemongroup: " + postinst)
   assert(postinst contains """addUser daemonuser daemongroup "debian-test user-daemon" "/bin/false"""", "postinst misses useradd for daemonuser: " + postinst)
   assert(postinst contains "chown daemonuser:daemongroup /var/log/debian-test", "postinst misses chown daemonuser /var/log/debian-test: " + postinst)
-  assert(postinst contains "chown daemonuser:daemongroup /var/run/debian-test", "postinst misses chown daemonuser /var/run/debian-test: " + postinst)
   assert(!(postinst contains "addgroup --system daemonuser"), "postinst has addgroup for daemonuser: " + postinst)
   assert(!(postinst contains "useradd --system --no-create-home --gid daemonuser --shell /bin/false daemonuser"), "postinst has useradd for daemongroup: " + postinst)
   assert(postrm contains "deleteUser daemonuser", "postrm misses purging daemonuser user: " + postrm)

src/sbt-test/debian/test-executableScriptName/test

@@ -11,7 +11,6 @@ $ exists target/debian-test-0.1.0/usr/share/debian-test/
 $ exists target/debian-test-0.1.0/usr/share/debian-test/bin/
 $ exists target/debian-test-0.1.0/usr/share/debian-test/bin/debian-exec
 $ exists target/debian-test-0.1.0/var/log/debian-test/
-$ exists target/debian-test-0.1.0/var/run/debian-test/
 $ exists target/debian-test-0.1.0/etc/default/debian-test/
 # --------------------------------------------
 $ exists target/debian-test-0.1.0/etc/init/debian-test.conf

src/sbt-test/debian/test-packageName/test

@@ -9,7 +9,6 @@ $ exists target/debian-test-override-0.1.0/usr/
 $ exists target/debian-test-override-0.1.0/usr/share/
 $ exists target/debian-test-override-0.1.0/usr/share/debian-test-package/
 $ exists target/debian-test-override-0.1.0/var/log/debian-test-package/
-$ exists target/debian-test-override-0.1.0/var/run/debian-test-package/
 $ exists target/debian-test-override-0.1.0/etc/default/debian-test-package/
 # Testing control script 
 # TODO - Test that the generic mapping did the right thing.