Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dockerUpdateLatest doesn't update latest #1141

Closed
jtownley opened this issue Jul 31, 2018 · 4 comments
Closed

dockerUpdateLatest doesn't update latest #1141

jtownley opened this issue Jul 31, 2018 · 4 comments
Labels

Comments

@jtownley
Copy link

Expected behaviour

When dockerUpdateLatest in Docker := true in in build.sbt
and command sbt docker:publish is executed
should publish the version tag and latest tag to repo

Actual behaviour

  • Only version tag is published to repo
  • The lastest tag is not published if latest is not there
  • The lastest tag is not updated if it is there.

Information

  • What sbt-native-packager are you using: 1.3.6
  • What sbt version: 1.1.6
  • What is your build system (e.g. Ubuntu, MacOS, Windows, Debian ): Mac (10.13.6)
  • What package are you building (e.g. docker, rpm, ...): docker

Docker Version:

docker version
Client:
 Version:           18.06.0-ce
 API version:       1.38
 Go version:        go1.10.3
 Git commit:        0ffa825
 Built:             Wed Jul 18 19:05:26 2018
 OS/Arch:           darwin/amd64
 Experimental:      false

Server:
 Engine:
  Version:          18.06.0-ce
  API version:      1.38 (minimum version 1.12)
  Go version:       go1.10.3
  Git commit:       0ffa825
  Built:            Wed Jul 18 19:13:46 2018
  OS/Arch:          linux/amd64
  Experimental:     true

Of Note:

  • Publishing to nexus repository.
  • version tag publishes correctly.
  • Doesn't have any information in the log about even trying this.
@muuki88
Copy link
Contributor

muuki88 commented Jul 31, 2018

Thanks for your detailed nnig report 👍

Have you tried

dockerUpdateLatest := true

Settings already prefixed with docker* don't require any additional scoping.

@muuki88 muuki88 added the docker label Aug 2, 2018
@tonyamelnychuk
Copy link

tonyamelnychuk commented May 27, 2019

Are there any updates on this fix? It seems I faced the same issue: this dockerUpdateLatest := true does not update an existing docker image tagged as 'latest' if I run docker/publish i.e 2 times .
I expected that it has to update the latest image with every new module version..

@nimaeskandary
Copy link

I'm having issues with a multi project build (github.com/vinyldns). If i set dockerUpdateLatest to true it does not update latest nor if I set dockerUpdateLatest in project1 to true

@muuki88
Copy link
Contributor

muuki88 commented Jul 10, 2019

It seems I faced the same issue: this dockerUpdateLatest := true does not update an existing docker image tagged as 'latest' if I run docker/publish i.e 2 times

If the build returns the same output, the docker image shouldn't change, right? We configure dockerAliases (see DockerPlugin) with a latest tag.

The dockerAliases are then appended to the dockerBuildOptions in the form of -t ${alias.toString}, see DockerPlugin. This should result in somthing like

$ docker build --force-rm -t aliasOne -t latest .

@muuki88 muuki88 closed this as completed Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants