Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in Docker Plugin Force Latest Parameter Sequence? #555

Closed
AshleyAitken opened this issue Apr 17, 2015 · 3 comments
Closed

Error in Docker Plugin Force Latest Parameter Sequence? #555

AshleyAitken opened this issue Apr 17, 2015 · 3 comments
Labels

Comments

@AshleyAitken
Copy link

Howdy All,

I'm pretty much a beginner at all of this so please understand if this is incorrect.
I am trying to force the "latest" tag in docker native packager and it seems to fail all the time.

I believe this line in DockerPlugin.scala Line 288

val latestCmd = Seq("docker", "tag", "-f", tag, name)

should be

val latestCmd = Seq("docker", "tag", "-f", name, tag)

i.e. sequence of name and tag is incorrect.
If this is an error is it possible to fix please (or do I need to submit a pull request etc).
Thanks,
Ashley.

@muuki88 muuki88 added the docker label Apr 17, 2015
@muuki88
Copy link
Contributor

muuki88 commented Apr 17, 2015

docker tag --help says (and docs)

Usage: docker tag [OPTIONS] IMAGE[:TAG] [REGISTRYHOST/][USERNAME/]NAME[:TAG]

Examples show that id comes first and then the tag:

$ sudo docker tag 5db5f8471261 ouruser/sinatra:devel

So I think this should work as we have tests for this as well.

@muuki88 muuki88 closed this as completed Apr 17, 2015
@AshleyAitken
Copy link
Author

Sorry @muuki88 I was confused by that, you are right.

@muuki88
Copy link
Contributor

muuki88 commented Apr 18, 2015

No problem :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants