Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback on using JDKPackagerPlugin for some days (creating MSI) #594

Closed
akauppi opened this issue Jun 5, 2015 · 4 comments
Closed

Feedback on using JDKPackagerPlugin for some days (creating MSI) #594

akauppi opened this issue Jun 5, 2015 · 4 comments

Comments

@akauppi
Copy link

akauppi commented Jun 5, 2015

The plugin really makes things easier. The documented features work, but I noticed some things I would want that are currently not supported.

  1. Ability to launch the installed program right after installation. I do not know if this is possible via the ant-javafx.jar, either.
  2. Ability to build in a specific, local JRE instead of the system default.
  3. For some reason I am unable to sign the created MSI (separately, using signtool). Not asking signing to be included, but if the output MSI format is not allowing signing, that's a bug somewhere.
  4. The icon in the Remove Programs list cannot be customized.

I'm just listing these as a feedback, and for others considering using the plugin. Unfortunately cannot help in adding such features. Sorry.

@metasim
Copy link
Member

metasim commented Jun 5, 2015

@akuppi Thanks so much for the feedback!

As for Item 1, I think this is the default if you use InnoSetup instead of WiX. My memory is that if you select all or installers as the package type, the javapackager tasks will build all the ones it can, based on the tools available on the system. Also know that you can override the default InnoSetup or WiX configuration files. See here for details, but know I've not fully tested out this to ensure that the build.xml file the plugin generates properly configures the classpath.

Item 2: Not sure about this one. I thought I remembered seeing something in the past where one could configure this, but scouring the docs doesn't result in anything I can find.

Item 3: I'd take a look at the WiX documentation on that front. Please let us know if you find anything. Keep an eye on the bundle arguments documentation, as this is where the MacOS signing stuff is, and where I'd expect Oracle to add Windows support in subsequent releases.

Item 4: I think you'll have to go the route of drop-in resources (Item 1) to be able to do this, but not sure.

IHTH.

@metasim
Copy link
Member

metasim commented Jun 5, 2015

On Item 2, looking at the Windows specific docs for the command line javapackager tool (which uses the same code as the ant tasks IIRC), it references a bundle argument runtime=path that can be assigned via the command line via the -B option. So I'm wondering if you set a bundle argument (via the generated build.xml, file until I expose that to sbt) if that would do the trick?

@metasim
Copy link
Member

metasim commented Aug 9, 2015

@akauppi Per item 4, a colleague of mine figured out that if you use InnoSetup instead of WiX as the backend, the uninstaller icon is properly synced. I suspect this is a bug in javapackager WiX template.

Interested in knowing if you find a solution to item 3. I don't have experience signing Windows applications.

@akauppi
Copy link
Author

akauppi commented Aug 9, 2015

Unfortunately, I remember very little of this, now two months later. We ended up doing the installer a completely different way.

@metasim metasim closed this as completed Aug 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants