Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Report: Benchmark tests are broken on master #278

Closed
3 tasks done
matthewfeickert opened this issue Sep 20, 2018 · 2 comments
Closed
3 tasks done

Bug Report: Benchmark tests are broken on master #278

matthewfeickert opened this issue Sep 20, 2018 · 2 comments
Assignees
@kratsg
Labels
bug Something isn't working

Comments

@matthewfeickert
Copy link
Member

Description

PR #276 caused the benchmark tests to fail. This seems to be tied to changes in the conftest.py.

Steps to Reproduce

Travis CI log

Checklist

  • Run git fetch to get the most up to date version of master
  • Searched through existing Issues to confirm this is not a duplicate issue
  • Filled out the Description, Expected Behavior, Actual Behavior, and Steps to Reproduce sections above or have edited/removed them in a way that fully describes the issue
@matthewfeickert matthewfeickert added the bug Something isn't working label Sep 20, 2018
@matthewfeickert
Copy link
Member Author

@kratsg I won't have time to look at this until the evening, so as you wrote the PR and probably still have the changes mentally cached if you have time to look at this it could be helpful.

@kratsg
Copy link
Contributor

kratsg commented Sep 20, 2018

Fixed in #268.

@kratsg kratsg closed this as completed Sep 20, 2018
@kratsg kratsg self-assigned this Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kratsg kratsg

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kratsg @matthewfeickert