Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate use of Array API #509

Open
matthewfeickert opened this issue Jul 12, 2019 · 4 comments
Open

Investigate use of Array API #509

matthewfeickert opened this issue Jul 12, 2019 · 4 comments
Assignees
Labels
feat/enhancement New feature or request follow up research experimental stuff

Comments

@matthewfeickert
Copy link
Member

Description

In discussions with @rgommers, @jrbourbeau, @jakirkham at SciPy 2019 it was brought up that given the adoption of the (NumPy) Array API across multiple libraries that we should see how this can be used in pyhf, particularly with respect to CuPy (Issue #238) and Dask (Issue #259).

They would be interested in getting feedback on how useful this API adoption is, so we should also do a good job of noting this in our PRs and then given them a short writeup about our experience (or maybe a blog post).

@matthewfeickert matthewfeickert added feat/enhancement New feature or request follow up research experimental stuff labels Jul 12, 2019
@matthewfeickert matthewfeickert self-assigned this Jul 12, 2019
@matthewfeickert
Copy link
Member Author

matthewfeickert commented Jul 12, 2019

As I'm the one proposing this work, I am happy to be the one documenting this it. Though we will need to address the other Issues first.

@lukasheinrich
Copy link
Contributor

if something like this exists I'd be very excited to adopt this. The slight mismatches in APIs between the backends become quite annoying. Originally I was thinking if Tensorly for this #131.

@matthewfeickert
Copy link
Member Author

The slight mismatches in APIs between the backends become quite annoying.

This won't help with the TensorFlow and PyTorch backends, as they have decided to not conform to the NumPy API and I don't see them radically changing their APIs. But this would help with everything else.

Originally I was thinking if Tensorly for this #131.

Yeah, I was looking at Tensorly the other day as well. This might be something to revisit in the future, but I'm also not sure if the API advantages that Tensorly would give would be worth taking it on as another core dependency that we would be very fragile to.

@kratsg
Copy link
Contributor

kratsg commented Jul 15, 2019

Tensorly looks to be doing something similar to what we've been doing -- which is interesting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat/enhancement New feature or request follow up research experimental stuff
Projects
None yet
Development

No branches or pull requests

3 participants