Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chat word wrapping kinda sucks #252

Open
Bios-Marcel opened this issue Mar 13, 2021 · 0 comments
Open

Chat word wrapping kinda sucks #252

Bios-Marcel opened this issue Mar 13, 2021 · 0 comments
Labels
enhancement improvement of any kind good first issue Good for newcomers hacktoberfest Good first issue for hacktoberfest! help wanted Extra attention is needed

Comments

@Bios-Marcel
Copy link
Member

Bios-Marcel commented Mar 13, 2021 •
edited
Loading

Right now, the word breaking isn't using hyphens and we break words aggressively. While overflow-wrap: break-word would be an improvement over word-break: break-all (word-break: break-word is deprecated), the desired thing would be hyphens.

While there's the hyphens property, it is dictionary aware, meaning that i wouldn't properly work, depending on the lobby language.

In order to be able to use this, we need to do the following:

  1. Make sure all lobby languages are backed by a correct langauge code, for example en_US for american english
  2. Write unit tests to make sure locales are correct
  3. Put the property into all HTML documents via <html lang="enUS">. The property needs to be part of the BasePageConfig and passed via templates
  4. Find out who defines dictionaries and whether there's fallback mechanisms if a dictionary isn't available
  5. If there's no fallback, then we should use overflow-wrap: break-word instead

UPDATE

Status Quo:

firefox_3bs46tQDnh

The long words should be broken with a hyphen in order to not disturb the flow of reading.

After looking into the documentation, it seems this should pretty much work ootb: https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_text/Wrapping_breaking_text#adding_hyphens

There's an example that applies the desired behaviour, using overflow-wrap: break-word, just like we already do. The hyphen and hyphen-character values seem to make no difference either.
@Bios-Marcel Bios-Marcel added the enhancement improvement of any kind label Mar 13, 2021
@Bios-Marcel Bios-Marcel mentioned this issue Mar 22, 2021
Closed
@Bios-Marcel Bios-Marcel added help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest Good first issue for hacktoberfest! labels Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement improvement of any kind good first issue Good for newcomers hacktoberfest Good first issue for hacktoberfest! help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Bios-Marcel