Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use letter combinations to add German umlauts #241

Closed
2 tasks done
adnanhz opened this issue Oct 24, 2022 · 3 comments
Closed
2 tasks done

Use letter combinations to add German umlauts #241

adnanhz opened this issue Oct 24, 2022 · 3 comments
Labels
blocked Another issue is blocking feature New feature or request

Comments

@adnanhz
Copy link

adnanhz commented Oct 24, 2022

Terms

Description

Since I like to type fast, I usually like to have all the keyboards on my phone in the same QWERTY layout. The fact that the German keyboard here contains extra keys for the umlaut letters makes me type incorrectly due to the keys being displaced.

Given a standard QWERTY keyboard, I prefer to type for example: "Uebung" and have the keyboard automatically convert it to "Übung". I guess this is common if you're familiar with German :)

Contribution

I don't have Swift knowledge but I'll be very happy to dive in!

@adnanhz adnanhz added the feature New feature or request label Oct 24, 2022
@andrewtavis andrewtavis added the blocked Another issue is blocking label Oct 24, 2022
@andrewtavis
Copy link
Member

andrewtavis commented Oct 24, 2022

Hey @adnanhz! Thanks for opening the issue! 😊 As discussed over lunch, we don't have a menu for Scribe yet - the ever important #16 - so as of now this is blocked. With that being said, adding a menu will soon be a priority, and with that we can implement this as well :) Main priority now is #96 in which we're tracking some data issues that require a new data structure.

This is partially the layout and partially the autocorrect feature we were talking about. I think it makes sense to keep them both here as you have it, as with the layout changing the user will inherently need that correction feature :) This feature we'd have to check to make sure that there aren't actual instances of ue, ae and oe in German, as that would prevent the user from typing them with how we do replacement as of now. Maybe that'll have to wait for actual autocorrect in #2.

With all this being said, let's keep in touch on this! Thanks again! 🚀

@andrewtavis
Copy link
Member

Hey @adnanhz! We were checking the backlog today and came upon this issue. I checked in on the following:

This feature we'd have to check to make sure that there aren't actual instances of ue, ae and oe in German, as that would prevent the user from typing them with how we do replacement as of now.

There are words that contain these letters where they shouldn't be combined – for instance sauer for sower. Because of this, if we want to do this feature we'd need to either do word by word replacements that would get quite messy and would need to be disabled for Swiss German, or we'd need to implement a full autocorrect in #2. As #2 covers the full autocorrect issue, I'll close this one so work can be focused there :) :)

Hope you're well! Let's grab lunch here soon 😊

@github-project-automation github-project-automation bot moved this from Todo to Done in Scribe Board Jul 10, 2023
@andrewtavis andrewtavis mentioned this issue Jul 10, 2023
2 tasks
@adnanhz
Copy link
Author

adnanhz commented Aug 2, 2023

Hey @adnanhz! We were checking the backlog today and came upon this issue. I checked in on the following:

This feature we'd have to check to make sure that there aren't actual instances of ue, ae and oe in German, as that would prevent the user from typing them with how we do replacement as of now.

There are words that contain these letters where they shouldn't be combined – for instance sauer for sower. Because of this, if we want to do this feature we'd need to either do word by word replacements that would get quite messy and would need to be disabled for Swiss German, or we'd need to implement a full autocorrect in #2. As #2 covers the full autocorrect issue, I'll close this one so work can be focused there :) :)

Hope you're well! Let's grab lunch here soon 😊

Makes sense, thanks Andrew! Sorry for the late reply, it’s one of those times I reply to messages in my head and then realize I didn’t actually do it.

Glad to see progress on the project!

See you hopefully soon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Another issue is blocking feature New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants