Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use preStateTracer #840

Closed
lispc opened this issue Aug 29, 2023 · 1 comment
Closed

refactor: use preStateTracer #840

lispc opened this issue Aug 29, 2023 · 1 comment

Comments

@lispc
Copy link

lispc commented Aug 29, 2023

Describe the feature you would like

for this tx https://etherscan.io/tx/0x7713d8f46a5472d62d9512990bc6979e9d4fcacbfe7e838c6365146ff3310a1e,

we need witness to prove why the collision error happens.

let address = get_call_result(&geth_trace.struct_logs[index..])

anyway we fixed this problem in our l2geth scroll-tech/go-ethereum#488

How to fix: we need to use preStateTracer for this. It will be useful

the preStateTracer will be better than our parsing of struct logger

Additional context

the native (golang, not js) prestate tracer is not available at the time we wrote our codes.

@lispc lispc changed the title bug: lack of witness for create2 collision error bug: lack of witness for create2 collision error (mainnet test) Aug 29, 2023
@lispc lispc changed the title bug: lack of witness for create2 collision error (mainnet test) refactor: use preStateTracer Aug 29, 2023
@lispc lispc removed the low priority label Sep 6, 2023
@lispc
Copy link
Author

lispc commented Sep 20, 2023

done

@lispc lispc closed this as completed Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant