Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update errors #599

Closed
amontanez24 opened this issue Dec 16, 2022 · 0 comments · Fixed by #602
Closed

Update errors #599

amontanez24 opened this issue Dec 16, 2022 · 0 comments · Fixed by #602
Assignees
Labels
feature request Request for a new feature
Milestone

Comments

@amontanez24
Copy link
Contributor

Problem Description

As a developer, it would be helpful to have more descriptive error types, so that different types of crashes could be handled separately.

Expected behavior

  • Remove the Error class and replace all instances with the appropriate of the following. Add the new error type if not already created.
    • InvalidConfigError: Something is incorrect about the config. Use in any method that sets or updates the config:
      • column names in 'transformers' are different than 'sdtypes'
      • incorrect 'sdtypes'
      • incorrect transformer names
    • InvalidDataError: The data is ill-formed in some way. Use any time data is passed in and doesn't match the expected format
      • data in fit doesn't match config
      • data in transform doesn't match config
      • data in reverse_transform doesn't have the right columns"
    • TransformerNotFitError: Trying to use the HyperTransformer before fitting it
      • Transform (transform_subset) before fit
      • Reverse transform (reverse_transform_subset) before fit
      • create_anonymized_columns before fit
    • TransformerInputError: The input to the hypertransformer is incorrect
      • assigned transformer doesn't match the sdtype
    • TransformerProcessingError: Catch all for anything that doesn't fit into the above. NOTE - Only add this one if needed.
@amontanez24 amontanez24 added the feature request Request for a new feature label Dec 16, 2022
@amontanez24 amontanez24 added this to the 1.3.0 milestone Dec 16, 2022
@amontanez24 amontanez24 self-assigned this Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant