Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement SourceFilter::includes() to not depend on SourceMapper and to not perform filesystem traversal #6114

Open
sebastianbergmann opened this issue Jan 30, 2025 · 1 comment
Labels
feature/test-runner CLI test runner type/performance Issues related to resource consumption (time and memory)

Comments

@sebastianbergmann
Copy link
Owner

Originally suggested by @dantleech in #6111 (comment).

I think we should focus on SourceFilter::includes() first. Once we have a good solution for that we can look into extracting and reusing it for sebastianbergmann/php-code-coverage#386.

@sebastianbergmann sebastianbergmann added feature/test-runner CLI test runner type/performance Issues related to resource consumption (time and memory) labels Jan 30, 2025
@dantleech
Copy link
Contributor

dantleech commented Mar 7, 2025

Just as a heads up, I've started working on this and am currently mapping out the current behavior in tests. There is a third-paty package that may work or provide a basis for an implementation: https://github.com/webmozarts/glob but the behavior is not the same (it's based on Java's Ant globbing, so not a 1-1 match for PHP's glob).In anycase will see how difficult it is to replicate the glob/phpunit/php-file-iterator behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/test-runner CLI test runner type/performance Issues related to resource consumption (time and memory)
Projects
None yet
Development

No branches or pull requests

2 participants