Fix sample specs get overwritten on manage analyses save (#2415)

* Do not overwrite sample specs unless explicitely set

* Remove pdb

* Changelog

Author: xispa

CHANGES.rst

@@ -4,6 +4,7 @@ Changelog
 2.5.0 (unreleased)
 ------------------
 
+- #2415 Fix sample specs get overwritten on manage analyses save
 - #2413 Fix select custom value for queryselect widget
 - #2412 Layered listing searchable text adapter lookup
 - #2409 Fix empty results get interpreted as 0.0 by 2-Dimensional-CSV importer

src/bika/lims/browser/workflow/analysisrequest.py

@@ -439,7 +439,13 @@ def __call__(self, action, objects):
         hidden = map(lambda o: {
             "uid": api.get_uid(o), "hidden": self.is_hidden(o)
         }, services)
-        specs = map(lambda service: self.get_specs(service), services)
+
+        # Do not overwrite default result ranges set through sample
+        # specification field unless the edition of specs at analysis
+        # level is explicitely allowed
+        specs = []
+        if self.is_ar_specs_enabled:
+            specs = map(lambda service: self.get_specs(service), services)
 
         # Set new analyses to the sample
         sample.setAnalysisServicesSettings(hidden)
@@ -459,6 +465,14 @@ def __call__(self, action, objects):
         # Redirect the user to success page
         self.success([sample])
 
+    @property
+    def is_ar_specs_enabled(self):
+        """Returns whether the assignment of specs at analysis level within
+        sample context is enabled or not
+        """
+        setup = api.get_setup()
+        return setup.getEnableARSpecs()
+
     def is_hidden(self, service):
         """Returns whether the request Hidden param for the given obj is True
         """