Allow to create samples without analyses (#2162)

* Added field in senaite setup

* Added proxy field in bika setup

* Added logic in sample add form

* Changelog updated

Author: ramonski

CHANGES.rst

@@ -4,6 +4,7 @@ Changelog
 2.4.0 (unreleased)
 ------------------
 
+- #2162 Allow to create samples without analyses
 - #2160 Allow indexed attributes for ZCTextIndex in catalog API
 - #2158 Fix traceback when accessing registry
 - #2154 Cleanup the internal logic used for the creation of analysis objects

src/bika/lims/browser/analysisrequest/add2.py

@@ -132,6 +132,13 @@ def get_object_by_uid(self, uid):
             logger.warn("!! No object found for UID #{} !!")
         return obj
 
+    @viewcache.memoize
+    def analyses_required(self):
+        """Check if analyses are required
+        """
+        setup = api.get_setup()
+        return setup.getSampleAnalysesRequired()
+
     def get_currency(self):
         """Returns the configured currency
         """
@@ -1570,6 +1577,10 @@ def ajax_submit(self):
             if record.get("Client", False):
                 required_fields.pop('Client', None)
 
+            # Check if analyses are required for sample registration
+            if not self.analyses_required():
+                required_fields.pop("Analyses", None)
+
             # Contacts get pre-filled out if only one contact exists.
             # We won't force those columns with only the Contact filled out to
             # be required.

src/bika/lims/content/bikasetup.py

@@ -324,6 +324,17 @@ def getCounterTypes(self, instance=None):
                           "Group analyses by category for samples")
         ),
     ),
+    BooleanField(
+        "SampleAnalysesRequired",
+        schemata="Analyses",
+        default=True,
+        widget=BooleanWidget(
+            label=_("label_bikasetup_sampleanalysesrequired",
+                    default="Require sample analyses"),
+            description=_("description_bikasetup_sampleanalysesrequired",
+                          "Analyses are required for sample registration")
+        ),
+    ),
     BooleanField(
         'EnableARSpecs',
         schemata="Analyses",
@@ -1098,5 +1109,22 @@ def setCategorizeSampleAnalyses(self, value):
         if setup:
             setup.setCategorizeSampleAnalyses(value)
 
+    def getSampleAnalysesRequired(self):
+        """Get the value from the senaite setup
+        """
+        setup = api.get_senaite_setup()
+        # setup is `None` during initial site content structure installation
+        if setup:
+            return setup.getSampleAnalysesRequired()
+        return False
+
+    def setSampleAnalysesRequired(self, value):
+        """Set the value in the senaite setup
+        """
+        setup = api.get_senaite_setup()
+        # setup is `None` during initial site content structure installation
+        if setup:
+            setup.setSampleAnalysesRequired(value)
+
 
 registerType(BikaSetup, PROJECTNAME)

src/senaite/core/content/senaitesetup.py

@@ -103,6 +103,16 @@ class ISetupSchema(model.Schema):
         default=False,
     )
 
+    sample_analyses_required = schema.Bool(
+        title=_("title_senaitesetup_sampleanalysesrequired",
+                default=u"Require sample analyses"),
+        description=_(
+            "description_senaitesetup_sampleanalysesrequired",
+            default=u"Analyses are required for sample registration"
+        ),
+        default=True,
+    )
+
     ###
     # Fieldsets
     ###
@@ -112,6 +122,7 @@ class ISetupSchema(model.Schema):
         fields=[
             "immediate_results_entry",
             "categorize_sample_analyses",
+            "sample_analyses_required",
         ]
     )
 
@@ -233,3 +244,17 @@ def setCategorizeSampleAnalyses(self, value):
         """
         mutator = self.mutator("categorize_sample_analyses")
         return mutator(self, value)
+
+    @security.protected(permissions.View)
+    def getSampleAnalysesRequired(self):
+        """Returns if analyses are required in sample add form
+        """
+        accessor = self.accessor("sample_analyses_required")
+        return accessor(self)
+
+    @security.protected(permissions.ModifyPortalContent)
+    def setSampleAnalysesRequired(self, value):
+        """Allow/Disallow to create samples without analyses
+        """
+        mutator = self.mutator("sample_analyses_required")
+        return mutator(self, value)