Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worksheet: "Print" does not display/print partial results #288

Closed
ramonski opened this issue Oct 23, 2017 · 2 comments
Closed

Worksheet: "Print" does not display/print partial results #288

ramonski opened this issue Oct 23, 2017 · 2 comments
Assignees

Comments

@ramonski
Copy link
Contributor

Steps to reproduce

  • Create 2 new ARs and receive the Samples
  • Create a new Worksheet and add all Analyses of these ARs to the worksheet
  • Add results for the one of the two ARs (half of the Analyses) and submit the results for verification
  • Press the "Print" button

Current behavior

No results are displayed on the report

Expected behavior

Partial results are added to the report

Screenshot (optional)

ws17-0001_ _liscon_lims

localhost_8081_senaite_worksheets_ws17-0001_print

@xispa
Copy link
Member

xispa commented Oct 24, 2017

I see. The aim of this form is to allow the analyst to introduce results manually by hand (maybe he/she is not in the lab or there isn't any workstation available on place) and later retype the results when a workstation is available. So, we assumed this report is used before the introduction of any result. But totally agree, the report should display partial results, cause maybe the analyst needs some previous results to fill the report manually.

I suggest to make a distinction in the form itself depending on the analysis status. If the result is for an analysis that have been validated, then the result should be displayed more prominently (or 'as is'). If the result is for an analysis that haven't been yet verified, I'd add an start next to the result (in red color) and a prominent statement at the bottom in red too, something like "Provisional result, verification pending".

@ramonski ramonski changed the title Worksheet "Print" does not display/print partial results Worksheet: "Print" does not display/print partial results Oct 25, 2017
@ramonski ramonski self-assigned this Oct 25, 2017
@ramonski
Copy link
Contributor Author

Good point and we agree on that. I will start working on that now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants