From 6e77ca18f6e66e08bd5bcaf215c4acbcc6946129 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jordi=20Puiggen=C3=A9?= <jp@naralabs.com>
Date: Fri, 9 Aug 2019 00:29:56 +0200
Subject: [PATCH 1/3] Permissions for deactivate and active in client workflow
 were mixed

---
 .../default/workflows/senaite_client_workflow/definition.xml  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/bika/lims/profiles/default/workflows/senaite_client_workflow/definition.xml b/bika/lims/profiles/default/workflows/senaite_client_workflow/definition.xml
index ffdd3e0552..7597dc170e 100644
--- a/bika/lims/profiles/default/workflows/senaite_client_workflow/definition.xml
+++ b/bika/lims/profiles/default/workflows/senaite_client_workflow/definition.xml
@@ -144,7 +144,7 @@
   <transition transition_id="activate" title="Activate" new_state="active" trigger="USER" before_script="" after_script="" i18n:attributes="title">
     <action url="" category="workflow" icon="">Activate</action>
     <guard>
-      <guard-permission>senaite.core: Transition: Deactivate</guard-permission>
+      <guard-permission>senaite.core: Transition: Activate</guard-permission>
       <guard-expression>python:here.guard_handler("activate")</guard-expression>
     </guard>
   </transition>
@@ -152,7 +152,7 @@
   <transition transition_id="deactivate" title="Deactivate" new_state="inactive" trigger="USER" before_script="" after_script="" i18n:attributes="title">
     <action url="" category="workflow" icon="">Deactivate</action>
     <guard>
-      <guard-permission>senaite.core: Transition: Activate</guard-permission>
+      <guard-permission>senaite.core: Transition: Deactivate</guard-permission>
       <guard-expression>python:here.guard_handler("deactivate")</guard-expression>
     </guard>
   </transition>

From 9c341f4b23db17270adabf76f8865a4349d5bedd Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jordi=20Puiggen=C3=A9?= <jp@naralabs.com>
Date: Fri, 9 Aug 2019 00:32:13 +0200
Subject: [PATCH 2/3] Added importstep (workflow) in upgrade 1.3.2

---
 bika/lims/upgrade/v01_03_002.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/bika/lims/upgrade/v01_03_002.py b/bika/lims/upgrade/v01_03_002.py
index 49775bfcdf..4a615a23ed 100644
--- a/bika/lims/upgrade/v01_03_002.py
+++ b/bika/lims/upgrade/v01_03_002.py
@@ -43,5 +43,9 @@ def upgrade(tool):
 
     # -------- ADD YOUR STUFF BELOW --------
 
+    # Mixed permissions for transitions in client workflow
+    # https://github.com/senaite/senaite.core/pull/1419
+    setup.runImportStepFromProfile(profile, "workflow")
+
     logger.info("{0} upgraded to version {1}".format(product, version))
     return True

From 55135514182e7f49c06f86beb3e1eea708fb3917 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jordi=20Puiggen=C3=A9?= <jp@naralabs.com>
Date: Fri, 9 Aug 2019 00:33:41 +0200
Subject: [PATCH 3/3] Changelog

---
 CHANGES.rst | 1 +
 1 file changed, 1 insertion(+)

diff --git a/CHANGES.rst b/CHANGES.rst
index f1bef17961..1a4f072e3a 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -19,6 +19,7 @@ Changelog
 
 **Fixed**
 
+- #1419 Mixed permissions for transitions in client workflow
 - #1414 Occasional "OSError: [Errno 24] Too many open files" in frontpage