From 5bd6bc57301d3a187923daf8cc44564dc0354f48 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jordi=20Puiggen=C3=A9?= Date: Mon, 20 Nov 2017 16:52:59 +0100 Subject: [PATCH 1/2] Remove verbosity of UIDReference.get when no value is assigned --- bika/lims/browser/fields/uidreferencefield.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/bika/lims/browser/fields/uidreferencefield.py b/bika/lims/browser/fields/uidreferencefield.py index 58b8f04687..9d4fd3c29f 100644 --- a/bika/lims/browser/fields/uidreferencefield.py +++ b/bika/lims/browser/fields/uidreferencefield.py @@ -101,6 +101,8 @@ def get(self, context, **kwargs): :rtype: BaseContent | list[BaseContent] """ value = StringField.get(self, context, **kwargs) + if not value: + return [] if self.multiValued else None if self.multiValued: # Only return objects which actually exist; this is necessary here # because there are no HoldingReferences. This opens the @@ -125,6 +127,8 @@ def getRaw(self, context, aslist=False, **kwargs): :rtype: string | list[string] """ value = StringField.get(self, context, **kwargs) + if not value: + return [] if self.multiValued else None if self.multiValued: ret = value else: From b90e632fb1e294778a55ee0ff91134a4582314d7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jordi=20Puiggen=C3=A9?= Date: Mon, 20 Nov 2017 17:00:20 +0100 Subject: [PATCH 2/2] changelog --- CHANGES.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGES.rst b/CHANGES.rst index 6695468be9..9c72f89313 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -14,7 +14,7 @@ Changelog **Fixed** - +- #390 Remove log verbosity of UIDReference.get when value is None or empty **Security**