Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: priorityClass support #120

Closed
jpuskar opened this issue Oct 18, 2021 · 3 comments
Closed

Feature: priorityClass support #120

jpuskar opened this issue Oct 18, 2021 · 3 comments
Assignees
Labels
feature New feature
Milestone

Comments

@jpuskar
Copy link

jpuskar commented Oct 18, 2021

Hi, is it possible to set priorityClassName for the controller and webhook-server when using the operator installation method? I would like to make sure that the controller is not evicted in the event of resource contention.

I read through the manifests, and I think what would need to happen is that in spec.template.spec here:
https://github.com/senthilrch/kube-fledged/blob/master/deploy/kubefledged-operator/helm-charts/kubefledged/templates/deployment-controller.yaml#L16

We would need something like this:

{{- if .Values.controller.priorityClassName }}
      priorityClassName: "{{ .Values.controller.priorityClassName }}"
{{- end }}

And a similar option for the webhook's manifest.

Also, it might be worth adding this to the jobs' manifest also, so that we could specify caching jobs to be of a lower priority class than regular workloads.

I am aware that avoiding this situation by making good use of resource requests and limits is the best approach. However, I am trying to plan for resource contention events anyway in case of misconfiguration (stranger things have happened).

@senthilrch
Copy link
Owner

senthilrch commented Oct 19, 2021

@jpuskar : Thanks for raising this issue. I think adding this feature would be highly beneficial to gain control over assigning the right/required priority for kube-fledged and the jobs it creates...I'll have this implemented in the upcoming v0.10.0 release.

@senthilrch senthilrch changed the title priorityClass support Feature: priorityClass support Oct 19, 2021
@senthilrch senthilrch self-assigned this Oct 19, 2021
@senthilrch senthilrch added the feature New feature label Oct 19, 2021
@senthilrch senthilrch added this to the v0.9.0 milestone Oct 19, 2021
@senthilrch senthilrch removed this from the v0.9.0 milestone Jan 14, 2022
@senthilrch senthilrch added this to the v0.10.0 milestone Feb 23, 2022
@senthilrch
Copy link
Owner

SODACODE22: Raise PR against "develop" branch.

@bhuvanessr
Copy link
Contributor

I'd like to work on this issue. assign to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

No branches or pull requests

3 participants