Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TODO: Update tokio to 1.0 #1021

Closed
kingbri1 opened this issue Oct 15, 2020 · 13 comments
Closed

TODO: Update tokio to 1.0 #1021

kingbri1 opened this issue Oct 15, 2020 · 13 comments
Labels
dependencies Related to Serenity dependencies. tracking Listing the progress on a particular development topic.

Comments

@kingbri1
Copy link
Contributor

kingbri1 commented Oct 15, 2020 •
edited
Loading

Opening an issue here as a reminder to update tokio to the latest version and fix any breaking changes.

NOTE: this is now v1.0
@arqunis arqunis added dependencies Related to Serenity dependencies. tracking Listing the progress on a particular development topic. labels Oct 15, 2020
@kingbri1
Copy link
Contributor Author

kingbri1 commented Nov 19, 2020 •
edited
Loading

Bumping this issue. Can someone list what dependencies need to be updated before we can update the lib?

@kingbri1
Copy link
Contributor Author

Reqwest: seanmonstar/reqwest#1076

@bahlo bahlo mentioned this issue Dec 10, 2020
Open
@bahlo
Copy link

bahlo commented Dec 10, 2020

async-tungstenite needs to be updated to 0.10.0

@evieluvsrainbows
Copy link
Contributor

@bahlo serenity's deps can't be updated to anything using tokio v0.3.x until reqwest gets updated and then all crates can be updated at once.

@bahlo
Copy link

bahlo commented Dec 10, 2020

@KamranMackey I'm aware – I was listing other dependencies that need to be updated as well as reqwest for Tokio 0.3. Didn't know you wanted to update all of them 👍

@kingbri1
Copy link
Contributor Author

Hyper needs to be updated to support v0.3 before reqwest can be updated, so it's going to be a while until this is completed.

@LunNova LunNova mentioned this issue Dec 12, 2020
Closed
@CalliEve
Copy link
Contributor

Hyper seems to be waiting on tokio to go stable and release its 1.0 version (which is expected to happen in the next weeks), before it then very soon after releases its v0.14.
v0.14 Release Checklist

@kingbri1
Copy link
Contributor Author

Once 1.0 releases, this issue will be updated to use that version instead of 0.3

@circumspect
Copy link
Contributor

tokio 1.0 is out: https://tokio.rs/blog/2020-12-tokio-1-0

@kingbri1 kingbri1 changed the title TODO: Update tokio to 0.3 TODO: Update tokio to 1.0 Dec 24, 2020
@kingbri1
Copy link
Contributor Author

Hyper has been upgraded to v0.14 according to the article.

@louy2 louy2 mentioned this issue Dec 31, 2020
Closed
@bryanhitc
Copy link

bryanhitc commented Jan 4, 2021 •
edited
Loading

Reqwest has merged the update: seanmonstar/reqwest#1076. Waiting on release

@bryanhitc
Copy link

bryanhitc commented Jan 5, 2021 •
edited
Loading

Reqwest v0.11 (which includes bytes v1.0, tokio v1.0, and hyper v0.14) has been released: seanmonstar/reqwest#1133. This issue should be unblocked now. See #1161

@kingbri1
Copy link
Contributor Author

kingbri1 commented Jan 5, 2021

Resolved by a27d7bb

@kingbri1 kingbri1 closed this as completed Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Related to Serenity dependencies. tracking Listing the progress on a particular development topic.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@evieluvsrainbows @bahlo @kingbri1 @bryanhitc @arqunis @CalliEve @circumspect