You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jan 12, 2023. It is now read-only.
Summary
Check and remove unecesseray subscription table break points in mp.css styling.
Details
Remove chapter 12 Tables in mp.css. This is redundant with other chapters and raises the user's expectation that the contained styles would be generically implemented in all tables, which isn't this case. The break points were meant for achieving some kind of responsiveness behaviour in the account subscriptions list. But it is only applied there.
(1) The required break point styles shall be sub classed with a meaningful class name like responsiveSubscriptionColumns or similar.
(2) An example of responsive rich table columns can be found the subscriptions details dialog with the parameters and options table. It is not necessary to toggle each column displaying. Only requirement is about the table content in mobile view, which needs the subscription name and status display only.
Thus two conditions should be sufficient here: media width >737px and media width <=738px.
(3) About mp.css: it is important to preserve the structure of this over 1k lines css file, and keep content related styles in same place, otherwise this file gets extremely unhandy.
The said styles shall be moved in the appropriate existing section of mp.css, where subscription table related styles are contained.
Acceptance criteria
Refactoring of chapter 12 and contained styles
Subscription list sub class with mobile and large view conditioned display styling
The text was updated successfully, but these errors were encountered:
Summary
Check and remove unecesseray subscription table break points in mp.css styling.
Details
Remove chapter 12 Tables in mp.css. This is redundant with other chapters and raises the user's expectation that the contained styles would be generically implemented in all tables, which isn't this case. The break points were meant for achieving some kind of responsiveness behaviour in the account subscriptions list. But it is only applied there.
(1) The required break point styles shall be sub classed with a meaningful class name like
responsiveSubscriptionColumns
or similar.(2) An example of responsive rich table columns can be found the subscriptions details dialog with the parameters and options table. It is not necessary to toggle each column displaying. Only requirement is about the table content in mobile view, which needs the subscription name and status display only.
Thus two conditions should be sufficient here: media width >737px and media width <=738px.
(3) About mp.css: it is important to preserve the structure of this over 1k lines css file, and keep content related styles in same place, otherwise this file gets extremely unhandy.
The said styles shall be moved in the appropriate existing section of mp.css, where subscription table related styles are contained.
Acceptance criteria
The text was updated successfully, but these errors were encountered: