Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the benchmarks #33

Closed
shama opened this issue Apr 20, 2013 · 1 comment
Closed

Fix the benchmarks #33

shama opened this issue Apr 20, 2013 · 1 comment

Comments

@shama
Copy link
Owner

shama commented Apr 20, 2013

The benchmarks have fallen out and should be updated and fixed to compare the impact of each commit.

@rgaskill
Copy link
Contributor

The benchmark test is missing changes because it is updating the file within a second of the timestamp on the file being changed. The OS X filesystem timestamp only has a time resolution of one second. So, any updates that happen within a second of the timestamp on the file will be missed by fs.watchFile because it sees no difference in the file timestamp (mtime).

This means the minimum time between changes that can be monitored is one second, but any file with a timestamp older than 1sec the change can be detected as fast as the poll cycle is. Does that make sense? It is a subtle distinction.

In the context of this benchmark test, one needs to wait at least a second after the creation of the test file and at least a second between each modification of the file or the change won't be detected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants