advanceOn doesn't complete tour

[ryanjm]

My last step has an advanceOn option on it but the complete event doesn't get called like it does when I tap the "Next" button.

I'd expect the advanceOn to behave the same was next would. If it is the end of the tour that would mark the tour as completed and call the complete event.

[geoffdaigle]

Hi @ryanjm, sorry for the delay on this response.

What's interesting is that, under the hood, shepherd does call next():
https://github.com/HubSpot/shepherd/blob/master/src/js/shepherd.js#L201-L208

I'll look into this, it might be a bug if I or someone else can reproduce the same problem you're having.

[crabmusket]

I've got the same issue going on. Will look into it at some point but I don't have the time for now, so I've worked around it using manual event listeners and a mediator.

[chuckcarpenter]

closing this one, as it's fixed and tested in 2.0 https://github.com/shipshapecode/shepherd/blob/master/test/unit/test.tour.js#L131